From d5bd538b92cecab1dbf7d2d836ba8289ba350cfd Mon Sep 17 00:00:00 2001 From: dario-piotrowicz Date: Thu, 18 Nov 2021 22:59:01 +0000 Subject: [PATCH] docs(animations): remove incorrect information regarding animateChild Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: #44014 For more context see issue #30477 --- aio/content/guide/animations.md | 4 ++-- aio/content/guide/route-animations.md | 12 ------------ packages/animations/src/animation_metadata.ts | 4 ---- 3 files changed, 2 insertions(+), 18 deletions(-) mode change 100755 => 100644 packages/animations/src/animation_metadata.ts diff --git a/aio/content/guide/animations.md b/aio/content/guide/animations.md index fade1da9fe63..62bccae9980a 100644 --- a/aio/content/guide/animations.md +++ b/aio/content/guide/animations.md @@ -289,7 +289,7 @@ What it does query() -Finds one or more inner HTML elements within the current element. +Finds one or more inner HTML elements within the current element. @@ -314,7 +314,7 @@ What it does animateChild() -Allows animations on child components to be run within the same timeframe as the parent. Note: Please see GitHub Issue #30477 before attempting to use animateChild() together with route transition animations. +Allows animations on child components to be run within the same timeframe as the parent. diff --git a/aio/content/guide/route-animations.md b/aio/content/guide/route-animations.md index 35bcfb08910a..b41cbab7fe5d 100644 --- a/aio/content/guide/route-animations.md +++ b/aio/content/guide/route-animations.md @@ -75,12 +75,6 @@ Animations can be defined directly inside your components. For this example you The following code snippet defines a reusable animation named `slideInAnimation`. -
- -**Note:** `animateChild()` does not currently work with route transition animations. Please see GitHub Issue #30477 for more information. - -
- The animation definition performs the following tasks: @@ -114,12 +108,6 @@ Use the `query()` method to find and animate elements within the current host co Assume that you are routing from the *Home => About*. -
- -**Note:** `animateChild()` does not currently work with route transition animations. Please see GitHub Issue #30477 for more information. - -
- The animation code does the following after styling the views: diff --git a/packages/animations/src/animation_metadata.ts b/packages/animations/src/animation_metadata.ts old mode 100755 new mode 100644 index 5c193a7811bf..b16ff6b2eb19 --- a/packages/animations/src/animation_metadata.ts +++ b/packages/animations/src/animation_metadata.ts @@ -1114,10 +1114,6 @@ export function animation( * with animations that are assigned using the Angular animation library. CSS keyframes * and transitions are not handled by this API. * - * `animateChild()` does not currently work with route transition animations. Please see - * GitHub Issue {@link https://github.com/angular/angular/issues/30477 #30477} for more - * information. - * * @publicApi */ export function animateChild(options: AnimateChildOptions|null = null):