Updates for TypeScript 1.6#4377
Conversation
There was a problem hiding this comment.
Should it be abstract (or a comment added if abstract is not supported yet)
There was a problem hiding this comment.
Oops! good catch.
On Fri, Sep 25, 2015 at 6:14 PM Victor Berchet notifications@github.com
wrote:
In modules/angular2/src/core/dom/dom_adapter.ts
#4377 (comment):@@ -9,137 +8,129 @@ export function setRootDomAdapter(adapter: DomAdapter) {
}
}-function _abstract() {
- return new BaseException('This method is abstract');
-}/* tslint:disable:requireParameterType /
/*
- Provides DOM operations in an environment-agnostic way.
*/
export class DomAdapter {Should it be abstract (or a comment added if abstract is not supported yet)
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/4377/files#r40488233.
ced3bba to
fa0a3b8
Compare
|
cc @tbosch |
d87d7c4 to
2dec249
Compare
There was a problem hiding this comment.
Are you planning to rename this file?
2dec249 to
49e490d
Compare
|
Merging PR #4377 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4377. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.