refactor(http): use Rx Observables in XHR backend#4376
Conversation
There was a problem hiding this comment.
Does ES6-style import not work here?
There was a problem hiding this comment.
This is the culprit in the typings failure, because TypeScript doesn't recognize Observable as a type here, just a variable.
There was a problem hiding this comment.
was going to ask - previously this had been CJS style, this is TS style, but ES6 style could be done.
There was a problem hiding this comment.
Ignore me. For now, just set observable types to "any"
|
Left some comments, but LGTM! |
f7f6eab to
731b61f
Compare
BREAKING CHANGE: Http now returns Rx Observables directly, so calling .toRx() is no longer necessary. Additionally, Http calls are now cold, so backend requests will not fire unless .subscribe() is called. closes angular#4043 and closes angular#2974
731b61f to
282f9a5
Compare
|
@jeffbcross comments addressed, jsonp_backend added as well. All green. |
|
Merging PR #4376 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-4376. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
BREAKING CHANGE: Http now returns Rx Observables directly, so calling .toRx() is no longer necessary. Additionally, Http calls are now cold, so backend requests will not fire unless .subscribe() is called.
Refactors XHR and JSONP backends to use RxJS Observables instead of EventEmitter implementation.
closes #4043 and closes #2974