chore(ts2dart): remove hand-written ts2dart typings#4372
Closed
alexeagle wants to merge 1 commit into
Closed
Conversation
c20fae4 to
1ed006c
Compare
Now that we are on TS 1.6, we can use the new node module resolution strategy.
1ed006c to
2900fdc
Compare
Contributor
There was a problem hiding this comment.
OOC, is anything preventing us from using ES6 syntax for all imports here (not saying to do it in this PR)?
Contributor
Author
There was a problem hiding this comment.
It depends on whether the other typings declare the "fs", "fs-extra", "path" modules. I think they do (the node.d.ts was updated to support ES6 output a while ago) so I think we could do this.
|
Merging PR #4372 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4372. |
Contributor
|
Nice! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are on TS 1.6, we can use the new node module resolution strategy.
cc @mprobst