docs(http): add language annotations and fix method value to enum#4348
Closed
mgechev wants to merge 1 commit into
Closed
docs(http): add language annotations and fix method value to enum#4348mgechev wants to merge 1 commit into
mgechev wants to merge 1 commit into
Conversation
Contributor
|
LGTM |
|
Merging PR #4348 on behalf of @tbosch to branch presubmit-tbosch-pr-4348. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added TypeScript syntax highlighting where I found type annotations.
Since #4331 will allow using strings as method names I think the method value in the example inside
static_request.tswill be more readable by importing and usingRequestMethodinstead of a numeric value.