refactor(views): split ViewManager/ViewContainerRef.createView into…#3114
Closed
tbosch wants to merge 1 commit into
Closed
refactor(views): split ViewManager/ViewContainerRef.createView into…#3114tbosch wants to merge 1 commit into
ViewManager/ViewContainerRef.createView into…#3114tbosch wants to merge 1 commit into
Conversation
… 2 methods BREAKING CHANGES: `ViewManager.createView` / `ViewContainerRef.create` have been split into 2 methods: - `createHostView` which takes dynamically created bindings - `createEmbeddedView` which takes the newly introduced `TemplateRef` The new type `TemplateRef` is the combination of a `ProtoViewRef` and and `ElementRef` from the same place. Use `TemplateRef` when working with embedded views in `ng-if`, `ng-for`, ... instead of `ProtoViewRef`. Also, `ProtoViewRef` is no more injectable, but `TemplateRef` is. First part of angular#1989 to clean up manual content projection.
085f2f1 to
dcbc02a
Compare
Contributor
Author
|
Reviewed in person with @vsavkin |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 2 methods
BREAKING CHANGES:
ViewManager.createView/ViewContainerRef.createhave been split into 2 methods:createHostViewwhich takes dynamically created bindingscreateEmbeddedViewwhich takes the newly introducedTemplateRefThe new type
TemplateRefis the combination of aProtoViewRefand andElementReffrom the same place. Use
TemplateRefwhen working with embedded views inng-if,ng-for, ... instead ofProtoViewRef.Also,
ProtoViewRefis no more injectable, butTemplateRefis.First part of #1989 to clean up manual content projection.