chore(build): add GCS upload of build artifacts#2946
Closed
alexeagle wants to merge 1 commit into
Closed
Conversation
This copies the dist/ folder for each successful travis run to a google cloud storage bucket, under the SHA of the commit. We only upload for submitted changes, not PRs. We can use this to fetch the dart sources for each SHA without having to re-build them, which is hard to reproduce since the environment might differ (eg. different Dart SDK)
Contributor
There was a problem hiding this comment.
technically not releases, just build artifacts.
Contributor
Author
There was a problem hiding this comment.
changed to angular2-snapshots
Contributor
Author
|
thanks, merged |
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Jul 9, 2015
second attempt after rollback of angular#2946 After each successful build in the dart stable variant, this uploads just enough of the dart artifacts to mirror what we would push to pub. By uploading the files instead of a zip, this lets dart users depend on an unreleased snapshot of angular2, and lets us easily fetch the dart artifacts for sync into google3 without having to re-build (potentially in a subtly different environment). This doesn't upload anything for pull requests.
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Jul 9, 2015
second attempt after rollback of angular#2946 After each successful build in the dart stable variant, this uploads just enough of the dart artifacts to mirror what we would push to pub. By uploading the files instead of a zip, this lets dart users depend on an unreleased snapshot of angular2, and lets us easily fetch the dart artifacts for sync into google3 without having to re-build (potentially in a subtly different environment). This doesn't upload anything for pull requests.
alexeagle
added a commit
that referenced
this pull request
Jul 9, 2015
second attempt after rollback of #2946 After each successful build in the dart stable variant, this uploads just enough of the dart artifacts to mirror what we would push to pub. By uploading the files instead of a zip, this lets dart users depend on an unreleased snapshot of angular2, and lets us easily fetch the dart artifacts for sync into google3 without having to re-build (potentially in a subtly different environment). This doesn't upload anything for pull requests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies the dist/ folder for each successful travis run
to a google cloud storage bucket, under the SHA of the commit.
We only upload for submitted changes, not PRs.
We can use this to fetch the dart sources for each SHA
without having to re-build them, which is hard to reproduce
since the environment might differ (eg. different Dart SDK)