chore(build): watch logger should honor ignoreInitial option#2101
Conversation
|
can you please move the logger into watcher? the rest lgtm |
|
The logger doesn't really have anything to do with scheduling, it's just there to print a message. It gets some information to help it print a more useful message |
|
the logger informs the user that a scheduled task is running. the logger should either be part of the callback or watcher, but not in this in between position as it is today. |
|
Making it part of the callback is a no-go because we're primarily using runSequence for those callbacks. It's more reusable this way anyhow |
It was confusing because the test.unit.dart task does ignore the initial, and the logger was hardcoded to always ignore the first task, leading to the appearance that a run was happening twice for no reason. Also, fixed the "fake ignoreInitial" handling to not rely on a fake event, which is not necessary.
|
if this fixes the original bug then let's get this merged. |
|
It may or may not "fix" the original bug. At the very least it will provide less confusing output. If that's all the original bug was, then it will be fixed. I'm not going to mark it as closing the bug. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
It was confusing because the test.unit.dart task does ignore the initial, and
the logger was hardcoded to always ignore the first task, leading to the appearance
that a run was happening twice for no reason.
Also, fixed the "fake ignoreInitial" handling to not rely on a fake event, which
is not necessary.
Closes #2093 (I think!)