Skip to content

fix(collection): new Set(iterable) is not supported (IE11, Safari)#2063

Closed
marclaval wants to merge 1 commit into
angular:masterfrom
marclaval:utSet
Closed

fix(collection): new Set(iterable) is not supported (IE11, Safari)#2063
marclaval wants to merge 1 commit into
angular:masterfrom
marclaval:utSet

Conversation

@marclaval
Copy link
Copy Markdown
Contributor

@marclaval
Copy link
Copy Markdown
Contributor Author

By the way, this PR fixes 24 unit tests in these browsers.

@marclaval marclaval force-pushed the utSet branch 2 times, most recently from d1355bf to 70d031e Compare May 22, 2015 08:34
@vicb
Copy link
Copy Markdown
Contributor

vicb commented May 22, 2015

I would change it to make it similar to what @chirayuk has done for Map.createFromPairs(), ie remove the need to test support each time a Set is created

@vicb vicb added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 22, 2015
@vicb vicb added @lgtm action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 22, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants