Skip to content

chore(gulp): log message when tasks triggered by watch#1893

Closed
caitp wants to merge 1 commit into
angular:masterfrom
caitp:issue-1882
Closed

chore(gulp): log message when tasks triggered by watch#1893
caitp wants to merge 1 commit into
angular:masterfrom
caitp:issue-1882

Conversation

@caitp
Copy link
Copy Markdown
Contributor

@caitp caitp commented May 14, 2015

Closes #1882

vicb
vicb reviewed May 14, 2015
View reviewed changes
Comment thread gulpfile.js Outdated
Copy link
Copy Markdown
Contributor

@vicb vicb May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick do you need "\n" here ?

Copy link
Copy Markdown
Contributor Author

@caitp caitp May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to get an extra linefeed, eg

====...
WATCH TRIGGERED ...

On: ...
====...

rather than

====...
WATCH TRIGGERED ...
On: ...
====...

--- formatting niceness with one less line of code, I guess

@vicb
Copy link
Copy Markdown
Contributor

vicb commented May 14, 2015

👍

gkalpak
gkalpak reviewed May 14, 2015
View reviewed changes
Comment thread gulpfile.js Outdated
Copy link
Copy Markdown
Member

@gkalpak gkalpak May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to not be used.

vicb
vicb reviewed May 14, 2015
View reviewed changes
Comment thread gulpfile.js Outdated
Copy link
Copy Markdown
Contributor

@vicb vicb May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caitp I would personally prefer the version without the extra-line, could you make it an option in the build system ;)

Copy link
Copy Markdown
Contributor Author

@caitp caitp May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If folks are happy with the less-tall version, there's no problem with that.

@caitp
Copy link
Copy Markdown
Contributor Author

caitp commented May 18, 2015

so eh, PTAL? @mhevery / @IgorMinar ? should be a trivial one =)

@mhevery mhevery added @lgtm action: merge The PR is ready for merge by the caretaker labels May 18, 2015
@mhevery mhevery self-assigned this May 18, 2015
caitp added a commit that referenced this pull request May 18, 2015
@caitp @mhevery
chore(gulp): log message when tasks triggered by watch
405d5c1 
Closes #1882

Closes #1893
@caitp caitp closed this in d9ceb42 May 18, 2015
@caitp caitp removed the in progress label May 18, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Have watch gulp targets print separators

5 participants

@caitp @vicb @gkalpak @mhevery @googlebot