Skip to content

fix(benchpress): only print the CV when it is meaningful#1444

Closed
srawlins wants to merge 1 commit into
angular:masterfrom
srawlins:meaningful-coefficient-of-variation
Closed

fix(benchpress): only print the CV when it is meaningful#1444
srawlins wants to merge 1 commit into
angular:masterfrom
srawlins:meaningful-coefficient-of-variation

Conversation

@srawlins
Copy link
Copy Markdown
Contributor

When the mean is 0, the coefficient of variation is calculated to be
NaN, which is not meaningful, so instead of printing "+-NaN%", just
don't print the CV at all.

Closes #908

When the mean is 0, the coefficient of variation is calculated to be
NaN, which is not meaningful, so instead of printing "+-NaN%", just
don't print the CV at all.

Closes angular#908
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mhevery mhevery added @lgtm action: merge The PR is ready for merge by the caretaker labels Apr 20, 2015
@mhevery mhevery closed this in 642e7e5 Apr 21, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: no

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in BenchPress output

3 participants