feat(view): replaced EventEmitter callback with EventEmitter observable#1376
Merged
Conversation
Contributor
There was a problem hiding this comment.
This lookup can be done outside the inner for loop.
Contributor
Author
|
@SekibOmazic we cannot use reflection to assign properties cause it will not perform well in Dart. We are thinking about using something like sweetjs to reduce the boilerplate. |
67eb786 to
d6f2255
Compare
Contributor
There was a problem hiding this comment.
please add code example to the comments
fddb715 to
d7d9e4f
Compare
Contributor
|
Please close #1250 when you merge this. |
a401fe0 to
cb94780
Compare
cb94780 to
233cb0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces EventEmitter callbacks with EventEmitter observables. It also updates forms to use EventEmitter.
Background:
We already use observables in forms and http. Imo we should use the same type in all these places. The added EventEmitter type implements the Observable/Stream interface and also allows pushing value.
A few things to note:
@mhevery @jeffbcross @yjbanov could you take a look?