feat(gestures): allow override of Hammer defaults#7924
Closed
kara wants to merge 1 commit into
Closed
Conversation
2885efa to
917e654
Compare
|
Merging PR #7924 on behalf of @alxhub to branch presubmit-alxhub-pr-7924. |
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: not ready for review
This PR enables the overriding of Hammer default thresholds when using gestures.
If you want to listen to Hammer gestures, you have to either keep the existing configuration or create your own Hammer event plugin with the configuration you want. This requires quite a bit of extra work if you just want to tweak a distance threshold.
You can now override the default Hammer config by defining your own HammerGestureConfig and adding it as a provider.
main.ts
Then, in your class, set an
overridesobject with the event names and your changes:MyHammerConfig.ts
If you want more control, you can instantiate Hammer any way you like by defining a
buildHammermethod that returns a Hammer instance instead (ignoring overrides object):MyHammerConfig.ts
No, existing code should not have to change.