WIP: feat(router): support regular expression route paths#7126
WIP: feat(router): support regular expression route paths#7126petebacondarwin wants to merge 43 commits into
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
3da234c to
0c795cb
Compare
|
@petebacondarwin can you update with status? we'd like to land this ahead of other router work so you don't end in refactoring hell. My understanding is this is on your to-do list, to resolve some remaining issues with Dart. |
|
Indeed - I have fixes almost ready to upload to GitHub right now. On 26 February 2016 at 18:47, Naomi Black notifications@github.com wrote:
|
f509247 to
67a053e
Compare
e7394b9 to
74842fd
Compare
|
+1 |
The current router is passed to the current component via a binding.
To indicate that this is an angular provided object, this commit
renames the binding to `$router`.
BREAKING CHANGE:
The recently added binding of the current router to the current component
has been renamed from `router` to `$router`.
So now the recommended set up for your bindings in your routed component
is:
```js
{
...
bindings: {
$router: '<'
}
}
```
The current router is passed to the current component via a binding.
To indicate that this is an angular provided object, this commit
renames the binding to `$router`.
BREAKING CHANGE:
The recently added binding of the current router to the current component
has been renamed from `router` to `$router`.
So now the recommended set up for your bindings in your routed component
is:
```js
{
...
bindings: {
$router: '<'
}
}
```
The issue indicated in the code was fixed in TypeScript 1.6
The issue indicated in the code was fixed in TypeScript 1.6
06c8530 to
26cf715
Compare
|
Closing this PR because it is superceded by #7325 which contains this work + fixes. |
@petebacondarwin deserves credit for most of this commit. This allows you to specify a regex and serializer function instead of the path DSL in your route declaration. ``` @RouteConfig([ { regex: '[a-z]+.[0-9]+', serializer: (params) => `{params.a}.params.b}`, component: MyComponent } ]) class Component {} ``` Closes angular#7325 Closes angular#7126
@petebacondarwin deserves credit for most of this commit. This allows you to specify a regex and serializer function instead of the path DSL in your route declaration. ``` @RouteConfig([ { regex: '[a-z]+.[0-9]+', serializer: (params) => `{params.a}.params.b}`, component: MyComponent } ]) class Component {} ``` Closes angular#7325 Closes angular#7126
@petebacondarwin deserves credit for most of this commit. This allows you to specify a regex and serializer function instead of the path DSL in your route declaration. ``` @RouteConfig([ { regex: '[a-z]+.[0-9]+', serializer: (params) => `{params.a}.params.b}`, component: MyComponent } ]) class Component {} ``` Closes #7325 Closes #7126
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is for @btford to look at and comment on...