Skip to content

add details to DehydratedException that hint at the source of the error#6939

Closed
justindujardin wants to merge 1 commit into
angular:masterfrom
justindujardin:dehydrated-exception-details
Closed

add details to DehydratedException that hint at the source of the error#6939
justindujardin wants to merge 1 commit into
angular:masterfrom
justindujardin:dehydrated-exception-details

Conversation

@justindujardin
Copy link
Copy Markdown
Contributor

@justindujardin justindujardin commented Feb 7, 2016

Purpose

When an application throws dehydrated exception errors, there is no information that hints at which piece of code is having issues. The AbstractChangeDetector instance has information that could make debugging easier.

Current:

Uncaught Attempt to use a dehydrated detector.
Uncaught Attempt to use a dehydrated detector.
Uncaught Attempt to use a dehydrated detector.
Uncaught Attempt to use a dehydrated detector.
Uncaught Attempt to use a dehydrated detector.

Proposed:

Uncaught Attempt to use a dehydrated detector: HostMdBackdrop_0 -> onHiding
Uncaught Attempt to use a dehydrated detector: HostMdBackdrop_0 -> onHiding
Uncaught Attempt to use a dehydrated detector: TestComponent_0 -> valueChange
Uncaught Attempt to use a dehydrated detector: MdSidenavContainer_0 -> onShown
Uncaught Attempt to use a dehydrated detector: TestComponent_0 -> onShown

@justindujardin
chore: add detail to dehydrated detector exception
fb83fe8 
 - at least I know what component is causing the error with this. without it the exception is so generic that it's not useful.
@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Feb 8, 2016
@IgorMinar IgorMinar closed this in e7ad03c Feb 9, 2016
@justindujardin justindujardin deleted the dehydrated-exception-details branch February 9, 2016 02:18
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justindujardin @vsavkin @googlebot