A way to override instances of PrimordialInjector in unit tests #614

Activity

1. mhevery

   added

   #core

   #core/mock

   #core/testing

   on Feb 11, 2015
2. mhevery

   added this to the M5: Early Adopters milestone on Feb 11, 2015
3. mhevery

   assigned

   vicb

   on Feb 19, 2015
4. mhevery

   modified the milestones: M6: Material Design Support, M5: Early Adopters on Feb 24, 2015
5. vicb commented on Mar 11, 2015

   

   vicb

   on Mar 11, 2015

   Contributor

   More actions

   @mhevery this could probably not land before we switch to TS as there is no way to introspect the type of anonymous fn parameters.

   However I have started to work on it, could you please give feedback on the following (we can discuss about it on our next sync)

   describe('describe', () => {
   
     // - beforeEach would be executed after beforeEachBindings
     // - then we can imagine that we could inject classes in the cb
     // - there is a gotcha with nested beforeEachBindings because we can not create
     //   the injector before all beforeEachBindings have been executed 
     beforeEach((c: AClass, async: AsyncCompleter) => {
       // injectabe ?
     });
   
     // IMO it's easier to define the bindings in a function rather than to have
     // bind() available in describe().
     // As of now the function should return a list of bindings, we use the same
     // syntax as in non-test code.
     beforeEachBindings(() => [
       AClass,
       bind(Router).toClass(MockRouter)
     ]);
   
     // It is possible to inject into it() callback.
     // AsyncCompleter allow completing async tests (like done in jasmine)
     it('it', (class: AClass, router: Router, async: AsyncCompleter) => {
      router.route().then(() => { async.done(); });
     });
   
     describe(..., () => {
       // This should be executed before any BeforeEach (even in the parent describe)
       // if we want to be able to inject into BeforeEach callbacks.
       beforeEachBindings(() => [
         BClass,
       ]);
   
       it(...);
   
     });
   })
6. vicb

   added

   in progress

   on Mar 13, 2015
7. vicb

   closed this as completedin #947on Mar 13, 2015
8. vicb

   removed

   in progress

   on Mar 13, 2015
9. angular-automatic-lock-bot commented on Sep 5, 2019

   

   angular-automatic-lock-botbot

   on Sep 5, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
10. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 5, 2019