Skip to content

declare peer dependencies as peer dependencies #5560

@jeffbcross

Description

@jeffbcross

Our package.json lists many peer dependencies as just dependencies, but should be reflected as peer dependencies:

  • reflect-metadata
  • rxjs
  • zone.js
  • es6-shim

This is to make sure duplicates don't end up in bundles, and to make sure Angular is sharing the same instances of modules. This is particularly important with RxJS where importing operators has a side effect of monkey-patching the Observable imported from rxjs/Observable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions