Skip to content

feat(core): renam AMBIENT_DIRECTIVES and AMBIENT_PIPES into PLATFORM_…#5201

Closed
vsavkin wants to merge 1 commit into
angular:masterfrom
vsavkin:ambient_to_platform
Closed

feat(core): renam AMBIENT_DIRECTIVES and AMBIENT_PIPES into PLATFORM_…#5201
vsavkin wants to merge 1 commit into
angular:masterfrom
vsavkin:ambient_to_platform

Conversation

@vsavkin

@vsavkin vsavkin commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

…DIRECTIVES and PLATFORM_PIPES

After discussing it we decided that PLATFORM_ is a better prefix for directives available everywhere in the app.

BREAKING CHANGE

AMBIENT_DIRECTIVES -> PLATFORM_DIRECTIVES
AMBIENT_PIPES -> PLATFORM_PIPES

…DIRECTIVES and PLATFORM_PIPES

After discussing it we decided that PLATFORM_ is a better prefix for directives available everywhere in the app.

BREAKING CHANGE

AMBIENT_DIRECTIVES -> PLATFORM_DIRECTIVES
AMBIENT_PIPES -> PLATFORM_PIPES
@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 9, 2015
@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Nov 10, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #5201 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-5201.

1 similar comment
@mary-poppins

Copy link
Copy Markdown

Merging PR #5201 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-5201.

@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Nov 10, 2015
@vsavkin vsavkin closed this in e27665c Nov 10, 2015
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants