fix(NgFor): allow default templates with ng-for-template#5161
Closed
pkozlowski-opensource wants to merge 1 commit into
Closed
fix(NgFor): allow default templates with ng-for-template#5161pkozlowski-opensource wants to merge 1 commit into
pkozlowski-opensource wants to merge 1 commit into
Conversation
|
Merging PR #5161 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-5161. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vsavkin sth I've discovered while playing with
ng-for-template. This small change makes it possible to have a "default" template insidengFor- a template that can be overridden with a non-null binding tong-for-template.In practice it allows us to write components that got default markup which can be, optionally, overridden from outside.