perf(dart/transform): Restrict visibility/mutability of codegen#5009
Closed
kegluneq wants to merge 1 commit into
Closed
perf(dart/transform): Restrict visibility/mutability of codegen#5009kegluneq wants to merge 1 commit into
kegluneq wants to merge 1 commit into
Conversation
a9f0eec to
d7adb23
Compare
For exported, generated templates, declare with `final` so `dart2js` knows they will never be reassigned. For non-exported, generated change detector classes, prefix the classname with `_` to mark them as internal.
d7adb23 to
47e9589
Compare
|
Merging PR #5009 on behalf of @tbosch to branch presubmit-tbosch-pr-5009. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For exported, generated templates, declare with
finalsodart2jsknows they will never be reassigned.
For non-exported, generated change detector classes, prefix the
classname with
_to mark them as internal.