-
Notifications
You must be signed in to change notification settings - Fork 27.2k
refreshAheadMs missing on serviceWorker config #46729
Copy link
Copy link
Closed
Labels
area: service-workerIssues related to the @angular/service-worker packageIssues related to the @angular/service-worker packagefeatureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issuesopen for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).An issue that is suitable for a community contributor (based on its complexity/scope).
Milestone
Description
Metadata
Metadata
Assignees
Labels
area: service-workerIssues related to the @angular/service-worker packageIssues related to the @angular/service-worker packagefeatureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issuesopen for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).An issue that is suitable for a community contributor (based on its complexity/scope).
Which @angular/* package(s) are relevant/related to the feature request?
service-worker
Description
The option
refreshAheadMsis not copied to the the ngsw.json in this code:angular/packages/service-worker/config/src/generator.ts
Lines 89 to 103 in 3a60063
Proposed solution
Add it there and the schema https://github.com/angular/angular/blob/253ac15ae89755f6830f3cf567c80de20d013663/packages/service-worker/config/schema.json
Alternatives considered
Have a block that is copied as is or have fields modified without recreating the config to avoid issues when new features are added to the service worker config. ie: clone the object before modifying it (calling parseDurationToMs...) to avoid loosing options... and have a looser schema