Skip to content

feat(render): re-export render and export DirectiveResolver - #2026

Closed
PatrickJS wants to merge 1 commit into
angular:masterfrom
PatrickJS:render-strategy
Closed

feat(render): re-export render and export DirectiveResolver#2026
PatrickJS wants to merge 1 commit into
angular:masterfrom
PatrickJS:render-strategy

Conversation

@PatrickJS

@PatrickJS PatrickJS commented May 20, 2015

Copy link
Copy Markdown
Contributor

If you want to use native web components in your App then your bootstrap file would look like this.

import {bootstrap} from 'angular2/angular2';
import {bind} from 'angular2/di';
import {ShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/shadow_dom_strategy';
import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy';

import {App} from './app';

bootstrap(App, [
  bind(ShadowDomStrategy).toClass(NativeShadowDomStrategy)
]);

rather than something like this

import {ShadowDomStrategy, NativeShadowDomStrategy} from 'angular2/render';
import {bootstrap, bind} from 'angular2/angular2';

import {App} from './app';

bootstrap(App, [
  bind(ShadowDomStrategy).toClass(NativeShadowDomStrategy)
]);

also complete a todo from @tbosch
https://github.com/angular/angular/blob/master/modules/angular2/core.js#L17

I'm re-exporting render in core unless you want me to remove it

it would also be nice to have DirectiveResolver exported in angular/core so I added that here.

@PatrickJS PatrickJS changed the title feat(pipe): re-export render to generate docs feat(render): re-export render May 20, 2015
@PatrickJS
PatrickJS force-pushed the render-strategy branch 4 times, most recently from b961154 to 3a4eada Compare May 20, 2015 22:02
@PatrickJS PatrickJS changed the title feat(render): re-export render feat(render): re-export render and export DirectiveResolver May 20, 2015
@naomiblack naomiblack added this to the M9: TypeScript and Build Stability milestone May 21, 2015
@naomiblack

naomiblack commented May 21, 2015

Copy link
Copy Markdown
Contributor

@tbosch can you review please?

@PatrickJS

PatrickJS commented May 21, 2015

Copy link
Copy Markdown
Contributor Author

I updated the PR so it should be green and ready to go

tbosch
tbosch reviewed May 22, 2015
View reviewed changes
Comment thread modules/angular2/render.ts Outdated

@tbosch tbosch May 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All exports from ./src/core/ should stay in angular2/core.ts.

@tbosch tbosch added @lgtm action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 22, 2015
@tbosch

tbosch commented May 22, 2015

Copy link
Copy Markdown
Contributor

Looks good besides the comment above.

@tbosch

tbosch commented May 22, 2015

Copy link
Copy Markdown
Contributor

And could you sqash into one commit?

@PatrickJS

PatrickJS commented May 22, 2015

Copy link
Copy Markdown
Contributor Author

@tbosch I updated the PR with your suggestions.
I removed export * from './render'; from core.ts and added core exports back.
I also added export * from './src/render/api'; to render.ts

@tbosch

tbosch commented May 23, 2015

Copy link
Copy Markdown
Contributor

@gdi2290 Could you rebase ontop of master?

@PatrickJS

PatrickJS commented May 23, 2015

Copy link
Copy Markdown
Contributor Author

@tbosch I pushed up the rebase

@tbosch tbosch closed this in 662da0d May 23, 2015
@tbosch

tbosch commented May 23, 2015

Copy link
Copy Markdown
Contributor

Thanks Patrick!

@PatrickJS
PatrickJS deleted the render-strategy branch May 23, 2015 00:41
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 6, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@tbosch tbosch

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

M09: TypeScript and Build Stability

Development

Successfully merging this pull request may close these issues.

4 participants

@PatrickJS @naomiblack @tbosch @googlebot