Repository navigation
Pull up and export lambdas in Annotations so that AoT Compiler can reference it. #13138
Description
Depends on:
- Rewrite Tsickle to use TypeScript v2.1 transforms API see Rewrite Tsickle to use TypeScript v2.1 transforms tsickle#285
In JIT mode this code works.
@NgModule({
providers: [
{provide: SomeSymbol, useFactor: (i) => i.get('someSymbol'), deps: ['$injector']}
]
})
export class MyModule {}
but in AoT it needs to be written like so:
export factoryForSomeSymbol = (i) => i.get('someSymbol');
@NgModule({
providers: [
{provide: SomeSymbol, useFactor: factoryForSomeSymbol, deps: ['$injector']}
]
})
export class MyModule {}
ngc should be smart enough together with tsickle to perform this operation automatically for the developer.
Activity
mhevery commentedon Nov 29, 2016
/cc @chuckjaz
shlomiassaf commentedon Jan 26, 2017
@mhevery @tbosch @chuckjaz
Now that microsoft/TypeScript#13604 is in master, and will be in 2.2 this is really important for implementing the mixin pattern.
A use case will be an ActiveRecord library like ngResource but with full type information.
chuckjaz commentedon Jan 26, 2017
@shlomiassaf I am uncertain how this issue is related to mixins and microsoft/TypeScript#13604. Can you go into more detail?
shlomiassaf commentedon Jan 26, 2017
I misinterpreted the proposal, it wont help :/
Mixins are functions which are not supported by the compiler, not tsickle, my bad.
Anyway, this only effects a mixin if you want to create a provider for it, then AOT wants a value.
JoostK commentedon Mar 14, 2020
This has been implemented in b6c4af6 for Angular 5.
angular-automatic-lock-bot commentedon Apr 14, 2020
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.