refactor(devtools): don't minify debug builds.

dgp1130 · thePunderWoman · commit fc55996b5611 · 2026-02-24T09:28:05.000-08:00
This disables esbuild minification when building DevTools in debug mode, introducing a new `//devtools:debug` flag and a `pnpm run devtools:build:chrome:dev` script to trigger it. This should make debugging a little easier.
diff --git a/devtools/BUILD.bazel b/devtools/BUILD.bazel
@@ -1,7 +1,20 @@
+load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
 load("//devtools/tools:defaults.bzl", "ts_config")
 
 package(default_visibility = ["//visibility:public"])
 
+bool_flag(
+    name = "debug",
+    build_setting_default = False,
+)
+
+config_setting(
+    name = "debug_build",
+    flag_values = {
+        ":debug": "True",
+    },
+)
+
 exports_files([
     "tsconfig.json",
     "cypress.json",
diff --git a/devtools/projects/shell-browser/src/BUILD.bazel b/devtools/projects/shell-browser/src/BUILD.bazel
@@ -42,7 +42,6 @@ esbuild(
     ],
     config = "//devtools/tools/esbuild:esbuild-esm-prod.config.mjs",
     entry_points = [":main.ts"],
-    minify = True,
     platform = "browser",
     splitting = False,
     target = "es2022",
@@ -62,7 +61,6 @@ esbuild(
     config = "//devtools/tools/esbuild:esbuild-esm.config.mjs",
     entry_point = "devtools.ts",
     format = "iife",
-    minify = True,
     platform = "browser",
     splitting = False,
     target = "es2022",
diff --git a/devtools/projects/shell-browser/src/app/BUILD.bazel b/devtools/projects/shell-browser/src/app/BUILD.bazel
@@ -213,7 +213,6 @@ esbuild(
     config = "//devtools/tools/esbuild:esbuild-iife.config.mjs",
     entry_point = "detect-angular.ts",
     format = "iife",
-    minify = True,
     platform = "browser",
     # Need to inline sourcemaps for injected scripts as Chrome doesn't seem to load them correctly otherwise.
     sourcemap = "inline",
@@ -234,7 +233,6 @@ esbuild(
     config = "//devtools/tools/esbuild:esbuild-iife.config.mjs",
     entry_point = "backend.ts",
     format = "iife",
-    minify = True,
     platform = "browser",
     # Need to inline sourcemaps for injected scripts as Chrome doesn't seem to load them correctly otherwise.
     sourcemap = "inline",
@@ -255,7 +253,6 @@ esbuild(
     config = "//devtools/tools/esbuild:esbuild-iife.config.mjs",
     entry_point = "ng-validate.ts",
     format = "iife",
-    minify = True,
     platform = "browser",
     # Need to inline sourcemaps for injected scripts as Chrome doesn't seem to load them correctly otherwise.
     sourcemap = "inline",
@@ -276,7 +273,6 @@ esbuild(
     config = "//devtools/tools/esbuild:esbuild-iife.config.mjs",
     entry_point = "background.ts",
     format = "iife",
-    minify = True,
     platform = "browser",
     splitting = False,
     target = "esnext",
@@ -295,7 +291,6 @@ esbuild(
     config = "//devtools/tools/esbuild:esbuild-iife.config.mjs",
     entry_point = "content-script.ts",
     format = "iife",
-    minify = True,
     platform = "browser",
     # Need to inline sourcemaps for injected scripts as Chrome doesn't seem to load them correctly otherwise.
     sourcemap = "inline",
diff --git a/devtools/tools/defaults.bzl b/devtools/tools/defaults.bzl
@@ -24,8 +24,12 @@ npm_sass_library = _npm_sass_library
 http_server = _http_server
 js_library = _js_library
 
-def esbuild(sourcemap = "linked", sources_content = True, **kwargs):
+def esbuild(minify = None, sourcemap = "linked", sources_content = True, **kwargs):
     _esbuild(
+        minify = minify if minify != None else select({
+            "//devtools:debug_build": False,
+            "//conditions:default": True,
+        }),
         sourcemap = sourcemap,
         sources_content = sources_content,
         **kwargs
diff --git a/package.json b/package.json
@@ -37,7 +37,9 @@
     "devtools:e2e:open": "cypress open --project ./devtools/cypress",
     "devtools:build:chrome": "bazelisk build --//devtools/projects/shell-browser/src:flag_browser=chrome //devtools/projects/shell-browser/src:prodapp",
     "devtools:build:firefox": "bazelisk build --config snapshot-build-firefox --//devtools/projects/shell-browser/src:flag_browser=firefox //devtools/projects/shell-browser/src:prodapp",
+    "devtools:build:chrome:debug": "pnpm run -s devtools:build:chrome --//devtools:debug",
     "devtools:build:chrome:release": "pnpm run -s devtools:build:chrome",
+    "devtools:build:firefox:debug": "pnpm run -s devtools:build:firefox --//devtools:debug",
     "devtools:build:firefox:release": "pnpm run -s devtools:build:firefox --jobs 4",
     "devtools:test": "bazelisk test --//devtools/projects/shell-browser/src:flag_browser=chrome -- //devtools/...",
     "devtools:test:unit": "bazelisk test -- //devtools/...",
