fix(core): guard window access in event replay and update misconfiguration tests

thePunderWoman · thePunderWoman · commit ae2777ccdd30 · 2026-04-08T13:30:16.000-07:00
Guards window access with typeof check in event_replay.ts to prevent ReferenceError in non-browser environments during SSR and tests. Updates platform-server tests to expect missing setup warnings only when incremental hydration is explicitly disabled via withNoIncrementalHydration().
diff --git a/packages/core/src/hydration/event_replay.ts b/packages/core/src/hydration/event_replay.ts
@@ -84,7 +84,7 @@ export function withEventReplay(): Provider[] {
           // is enabled, but there are no events configured in this application, in which case
           // we don't activate this feature, since there are no events to replay.
           const appId = inject(APP_ID);
-          isEnabled = !!window._ejsas?.[appId];
+          isEnabled = typeof window !== 'undefined' && !!window._ejsas?.[appId];
         }
         if (isEnabled) {
           performanceMarkFeature('NgEventReplay');
diff --git a/packages/platform-server/test/incremental_hydration_spec.ts b/packages/platform-server/test/incremental_hydration_spec.ts
@@ -41,6 +41,7 @@ import {
   provideClientHydration,
   withEventReplay,
   withIncrementalHydration,
+  withNoIncrementalHydration,
 } from '@angular/platform-browser';
 import {provideRouter, RouterLink, RouterOutlet, Routes} from '@angular/router';
 import {getAppContents, prepareEnvironmentAndHydrate, resetTViewsFor} from './dom_utils';
@@ -2998,7 +2999,7 @@ describe('platform-server partial hydration integration', () => {
   });
 
   describe('misconfiguration', () => {
-    it('should log a warning when `withIncrementalHydration()` is missing in SSR setup', async () => {
+    it('should log a warning when incremental hydration is disabled in SSR setup', async () => {
       @Component({
         selector: 'app',
         template: `
@@ -3012,8 +3013,8 @@ describe('platform-server partial hydration integration', () => {
       const appId = 'custom-app-id';
       const providers = [{provide: APP_ID, useValue: appId}];
 
-      // Empty list, `withIncrementalHydration()` is not included intentionally.
-      const hydrationFeatures = () => [];
+      // Explicitly disabled using withNoIncrementalHydration()
+      const hydrationFeatures = () => [withNoIncrementalHydration()];
       const consoleSpy = spyOn(console, 'warn');
       resetIncrementalHydrationEnabledWarnedForTests();
 
@@ -3022,7 +3023,7 @@ describe('platform-server partial hydration integration', () => {
       expect(consoleSpy).toHaveBeenCalledWith(jasmine.stringMatching('NG0508'));
     });
 
-    it('should log a warning when `withIncrementalHydration()` is missing in hydration setup', async () => {
+    it('should log a warning when incremental hydration is disabled in hydration setup', async () => {
       @Component({
         selector: 'app',
         template: `
@@ -3051,8 +3052,8 @@ describe('platform-server partial hydration integration', () => {
       const doc = getDocument();
       await prepareEnvironmentAndHydrate(doc, html, SimpleComponent, {
         envProviders: [...providers, {provide: PLATFORM_ID, useValue: 'browser'}],
-        // Empty list, `withIncrementalHydration()` is not included intentionally.
-        hydrationFeatures: () => [],
+        // Explicitly disabled using withNoIncrementalHydration()
+        hydrationFeatures: () => [withNoIncrementalHydration()],
       });
 
       expect(consoleSpy).toHaveBeenCalledTimes(1);

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export function withEventReplay(): Provider[] {`
`84`	`84`	`// is enabled, but there are no events configured in this application, in which case`
`85`	`85`	`// we don't activate this feature, since there are no events to replay.`
`86`	`86`	`const appId = inject(APP_ID);`
`87`		`- isEnabled = !!window._ejsas?.[appId];`
	`87`	`+ isEnabled = typeof window !== 'undefined' && !!window._ejsas?.[appId];`
`88`	`88`	`}`
`89`	`89`	`if (isEnabled) {`
`90`	`90`	`performanceMarkFeature('NgEventReplay');`