build: remove shelljs from build scripts (#64042)

josephperrott · kirjs · commit 9c29a40e1a0d · 2025-09-26T13:14:09.000-04:00
Remove shelljs from package building scripts PR Close #64042
diff --git a/scripts/build/angular-in-memory-web-api.mts b/scripts/build/angular-in-memory-web-api.mts
@@ -7,9 +7,8 @@
  */
 
 import {join} from 'path';
-import sh from 'shelljs';
 
-import {projectDir, bazelCmd, exec} from './package-builder.mjs';
+import {bazelCmd, exec} from './package-builder.mjs';
 
 /**
  * Build the `angular-in-memory-web-api` npm package and copies it into the release
@@ -28,12 +27,9 @@ export function buildAngularInMemoryWebApiPackage(destDir: string): void {
   console.info('  Building angular-in-memory-web-api npm package');
   console.info('##############################');
 
-  exec(`${bazelCmd} build //packages/misc/angular-in-memory-web-api:npm_package`);
-
-  // Create the output directory.
-  if (!sh.test('-d', destDir)) {
-    sh.mkdir('-p', destDir);
-  }
+  exec(`${bazelCmd} build //packages/misc/angular-in-memory-web-api:npm_package`, true);
+  // Ensure the output directory is available.
+  exec(`mkdir -p ${destDir}`);
 
   const bazelBinPath = exec(`${bazelCmd} info bazel-bin`, true);
 
@@ -44,7 +40,7 @@ export function buildAngularInMemoryWebApiPackage(destDir: string): void {
 
   console.info(`# Copy npm_package artifacts to ${distTargetDir}`);
 
-  sh.rm('-rf', distTargetDir);
-  sh.cp('-R', buildOutputDir, distTargetDir);
-  sh.chmod('-R', 'u+w', distTargetDir);
+  exec(`rm -rf ${distTargetDir}`);
+  exec(`cp -R ${buildOutputDir} ${distTargetDir}`);
+  exec(`chmod -R u+w ${distTargetDir}`);
 }
diff --git a/scripts/build/package-builder.mts b/scripts/build/package-builder.mts
@@ -6,14 +6,10 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {execSync} from 'child_process';
+import {execSync, spawnSync} from 'child_process';
 import {join, dirname} from 'path';
 import {BuiltPackage} from '@angular/ng-dev';
 import {fileURLToPath} from 'url';
-import sh from 'shelljs';
-
-// ShellJS should exit if a command fails.
-sh.set('-e');
 
 /** Path to the project directory. */
 export const projectDir: string = join(dirname(fileURLToPath(import.meta.url)), '../..');
@@ -76,26 +72,26 @@ function buildReleasePackages(
   // do this to ensure that the version placeholders are properly populated.
   packageNames.forEach((pkgName) => {
     const outputPath = getBazelOutputPath(pkgName);
-    if (sh.test('-d', outputPath)) {
-      sh.chmod('-R', 'u+w', outputPath);
-      sh.rm('-rf', outputPath);
+    if (spawnSync(`[ -d ${outputPath} ]`).status !== 0) {
+      exec(`chmod -R u+w ${outputPath}`);
+      exec(`rm -rf ${outputPath}`);
     }
   });
 
   exec(`${bazelCmd} build ${stampConfigArg} ${targets.join(' ')}`);
 
   // Delete the distribution directory so that the output is guaranteed to be clean. Re-create
   // the empty directory so that we can copy the release packages into it later.
-  sh.rm('-rf', distPath);
-  sh.mkdir('-p', distPath);
+  exec(`rm -rf ${distPath}`);
+  exec(`mkdir -p ${distPath}`);
 
   // Copy the package output into the specified distribution folder.
   packageNames.forEach((pkgName) => {
     const outputPath = getBazelOutputPath(pkgName);
     const targetFolder = getDistPath(pkgName);
     console.info(`> Copying package output to "${targetFolder}"`);
-    sh.cp('-R', outputPath, targetFolder);
-    sh.chmod('-R', 'u+w', targetFolder);
+    exec(`cp -R ${outputPath} ${targetFolder}`);
+    exec(`chmod -R u+w ${targetFolder}`);
   });
 
   return packageNames.map((pkg) => {
diff --git a/scripts/build/zone-js-builder.mts b/scripts/build/zone-js-builder.mts
@@ -7,9 +7,8 @@
  */
 
 import {join} from 'path';
-import sh from 'shelljs';
 
-import {projectDir, bazelCmd, exec} from './package-builder.mjs';
+import {bazelCmd, exec} from './package-builder.mjs';
 
 /**
  * Build the `zone.js` npm package into `dist/bin/packages/zone.js/npm_package/` and copy it to
@@ -29,11 +28,8 @@ export function buildZoneJsPackage(destDir: string): void {
   console.info('##############################');
 
   exec(`${bazelCmd} build //packages/zone.js:npm_package`);
-
-  // Create the output directory.
-  if (!sh.test('-d', destDir)) {
-    sh.mkdir('-p', destDir);
-  }
+  // Ensure the output directory is available.
+  exec(`mkdir -p ${destDir}`);
 
   const bazelBinPath = exec(`${bazelCmd} info bazel-bin`, true);
 
@@ -44,7 +40,7 @@ export function buildZoneJsPackage(destDir: string): void {
 
   console.info(`# Copy npm_package artifacts to ${distTargetDir}`);
 
-  sh.rm('-rf', distTargetDir);
-  sh.cp('-R', buildOutputDir, distTargetDir);
-  sh.chmod('-R', 'u+w', distTargetDir);
+  exec(`rm -rf ${distTargetDir}`);
+  exec(`cp -R ${buildOutputDir} ${distTargetDir}`);
+  exec(`chmod -R u+w ${distTargetDir}`);
 }
diff --git a/scripts/compare-main-to-patch.js b/scripts/compare-main-to-patch.js
@@ -19,7 +19,7 @@
  * features are only released to main.
  */
 
-const {exec} = require('shelljs');
+const {execSync} = require('child_process');
 const semver = require('semver');
 
 // Ignore commits that have specific patterns in commit message, it's ok for these commits to be
@@ -44,7 +44,7 @@ const initialVersion = 'initial';
 // Helper methods
 
 function execGitCommand(gitCommand) {
-  const output = exec(gitCommand, {silent: true});
+  const output = execSync(gitCommand, {silent: true});
   if (output.code !== 0) {
     console.error(`Error: git command "${gitCommand}" failed: \n\n ${output.stderr}`);
     process.exit(1);
