build: move dependencies on npm package of dev-infra to workspace dependency (#62083)

josephperrott · thePunderWoman · commit 78ec6ef89627 · 2025-06-24T10:46:13.000Z
Move from relying on the @npm// dependencies to aspect node modules where possible PR Close #62083
diff --git a/devtools/projects/demo-no-zone/src/BUILD.bazel b/devtools/projects/demo-no-zone/src/BUILD.bazel
@@ -38,7 +38,6 @@ filegroup(
     srcs = [
         ":index.html",
         ":styles.css",
-        "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",
     ],
 )
 
diff --git a/devtools/projects/demo-no-zone/src/index.html b/devtools/projects/demo-no-zone/src/index.html
@@ -10,7 +10,6 @@
   <body>
     <app-root></app-root>
 
-    <script src="./npm/node_modules/zone.js/bundles/zone.umd.min.js"></script>
     <script type="module" src="./bundle/main.js"></script>
   </body>
 </html>
diff --git a/devtools/projects/demo-standalone/src/BUILD.bazel b/devtools/projects/demo-standalone/src/BUILD.bazel
@@ -75,16 +75,15 @@ filegroup(
         ":browser_specific_styles",
         ":demo_styles",
         ":index.html",
+        "//:node_modules/zone.js",
         "//devtools/projects/demo-standalone/src/assets",
-        "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",
     ],
 )
 
 pkg_web(
     name = "devapp",
     srcs = [":dev_app_static_files"] + [
         ":bundle",
-        "@npm//:node_modules/tslib/tslib.js",
     ],
 )
 
diff --git a/devtools/projects/demo-standalone/src/index.html b/devtools/projects/demo-standalone/src/index.html
@@ -18,7 +18,7 @@
       <app-root></app-root>
     </div>
 
-    <script src="./npm/node_modules/zone.js/bundles/zone.umd.min.js"></script>
+    <script src="./node_modules/zone.js/bundles/zone.umd.min.js"></script>
     <script type="module" src="./bundle/main.js"></script>
   </body>
 </html>
diff --git a/devtools/projects/protocol/BUILD.bazel b/devtools/projects/protocol/BUILD.bazel
@@ -20,9 +20,6 @@ ts_project(
     interop_deps = [
         "//packages/core",
     ],
-    deps = [
-        "@npm//@types",
-    ],
 )
 
 ts_test_library(
@@ -35,7 +32,6 @@ ts_test_library(
     ],
     deps = [
         ":protocol_rjs",
-        "@npm//@types",
     ],
 )
 
diff --git a/devtools/projects/shell-browser/src/BUILD.bazel b/devtools/projects/shell-browser/src/BUILD.bazel
@@ -109,7 +109,7 @@ filegroup(
         ":browser_specific_styles",
         ":index.html",
         ":shell_common_styles",
-        "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",
+        "//:node_modules/zone.js",
     ],
 )
 
diff --git a/devtools/projects/shell-browser/src/app/BUILD.bazel b/devtools/projects/shell-browser/src/app/BUILD.bazel
@@ -69,7 +69,6 @@ ts_project(
         "//devtools/projects/ng-devtools-backend/src/lib/ng-debug-api",
         "//devtools/projects/protocol",
         "//devtools/projects/protocol:protocol_rjs",
-        "@npm//@types",
     ],
 )
 
diff --git a/devtools/projects/shell-browser/src/environments/BUILD.bazel b/devtools/projects/shell-browser/src/environments/BUILD.bazel
@@ -9,6 +9,5 @@ ts_project(
     ],
     deps = [
         "//devtools/projects/ng-devtools",
-        "@npm//@types",
     ],
 )
diff --git a/devtools/src/BUILD.bazel b/devtools/src/BUILD.bazel
@@ -86,8 +86,7 @@ pkg_web(
     name = "devapp",
     srcs = [":dev_app_static_files"] + [
         ":bundle",
-        "@npm//:node_modules/tslib/tslib.js",
-        "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",
+        "//:node_modules/zone.js",
     ],
 )
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,6 @@ filegroup(`
`38`	`38`	`srcs = [`
`39`	`39`	`":index.html",`
`40`	`40`	`":styles.css",`
`41`		`- "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",`
`42`	`41`	`],`
`43`	`42`	`)`
`44`	`43`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ filegroup(`
`109`	`109`	`":browser_specific_styles",`
`110`	`110`	`":index.html",`
`111`	`111`	`":shell_common_styles",`
`112`		`- "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",`
	`112`	`+ "//:node_modules/zone.js",`
`113`	`113`	`],`
`114`	`114`	`)`
`115`	`115`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ ts_project(`
`69`	`69`	`"//devtools/projects/ng-devtools-backend/src/lib/ng-debug-api",`
`70`	`70`	`"//devtools/projects/protocol",`
`71`	`71`	`"//devtools/projects/protocol:protocol_rjs",`
`72`		`- "@npm//@types",`
`73`	`72`	`],`
`74`	`73`	`)`
`75`	`74`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,5 @@ ts_project(`
`9`	`9`	`],`
`10`	`10`	`deps = [`
`11`	`11`	`"//devtools/projects/ng-devtools",`
`12`		`- "@npm//@types",`
`13`	`12`	`],`
`14`	`13`	`)`
Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,7 @@ pkg_web(`
`86`	`86`	`name = "devapp",`
`87`	`87`	`srcs = [":dev_app_static_files"] + [`
`88`	`88`	`":bundle",`
`89`		`- "@npm//:node_modules/tslib/tslib.js",`
`90`		`- "@npm//:node_modules/zone.js/bundles/zone.umd.min.js",`
	`89`	`+ "//:node_modules/zone.js",`
`91`	`90`	`],`
`92`	`91`	`)`
`93`	`92`