Skip to content

Commit 4739bde

Browse files
erkamyamanatscott
authored andcommitted
docs: fix typos and grammar errors across documentation
Fix various typos, misspellings, and grammar issues across contributing docs, adev content guides, and agent skills documentation. - "an minimum" β†’ "a minimum" (CONTRIBUTING.md) - "GitHub accounts" β†’ "GitHub account" (CONTRIBUTING.md) - "decendants" β†’ "descendants" (components/styling.md) - "templates are using" β†’ "templates is using" (hydration.md) - "A automated" β†’ "An automated" (branches-and-versioning.md) - "Github" β†’ "GitHub" (branches-and-versioning.md, commit-message-guidelines.md) - "practices makes" β†’ "practice makes" (caretaking.md) - "corresponds" β†’ "correspond" (triage-and-labelling.md) - "one a line" β†’ "a line" (documentation-authoring.md) - "straight forward" β†’ "straightforward" (using-fixup-commits.md) - "or you decide" β†’ "or you can decide" (anatomy-of-components.md) - "whenver" β†’ "whenever" (angular-new-app/SKILL.md)
1 parent b16a8a3 commit 4739bde

File tree

10 files changed

+15
-15
lines changed

10 files changed

+15
-15
lines changed

β€ŽCONTRIBUTING.mdβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ You can file new issues by selecting from our [new issue templates](https://gith
7171

7272
### <a name="pr-quality"></a> Contribution Quality
7373

74-
We strongly value open source contribution and pull requests from community contributors. Please note that every pull request is reviewed and merged by an actual person on the team, which does take time and effort. That is time and effort that does take away from other valuable work. With that in mind we have an minimum set of expectations that are required of any community contribution pull request that is opened.
74+
We strongly value open source contribution and pull requests from community contributors. Please note that every pull request is reviewed and merged by an actual person on the team, which does take time and effort. That is time and effort that does take away from other valuable work. With that in mind we have a minimum set of expectations that are required of any community contribution pull request that is opened.
7575

7676
1. Search [GitHub](https://github.com/angular/angular/pulls) for an open or closed PR that relates to your submission.
7777
- You don't want to duplicate existing efforts.
@@ -238,7 +238,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
238238
- For corporations, we'll need you to
239239
[print, sign and one of scan+email, fax or mail the form][corporate-cla].
240240

241-
If you have more than one GitHub accounts, or multiple email addresses associated with a single GitHub account, you must sign the CLA using the primary email address of the GitHub account used to author Git commits and send pull requests.
241+
If you have more than one GitHub account, or multiple email addresses associated with a single GitHub account, you must sign the CLA using the primary email address of the GitHub account used to author Git commits and send pull requests.
242242

243243
The following documents can help you sort out issues with GitHub accounts and multiple email addresses:
244244

β€Žadev/src/content/guide/components/anatomy-of-components.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ You can alternatively choose to write your template and styles in separate files
5151
export class ProfilePhoto {}
5252
```
5353

54-
This can help separate the concerns of _presentation_ from _behavior_ in your project. You can choose one approach for your entire project, or you decide which to use for each component.
54+
This can help separate the concerns of _presentation_ from _behavior_ in your project. You can choose one approach for your entire project, or you can decide which to use for each component.
5555

5656
Both `templateUrl` and `styleUrl` are relative to the directory in which the component resides.
5757

β€Žadev/src/content/guide/components/styling.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ For example:
9494

9595
So, in effect, the `<a>` element may be in the component's template, or in any of its projected or child content.
9696

97-
- With `:host ::ng-deep p a`, both the `<a>` and `<p>` elements must be decendants of the component's host element.
97+
- With `:host ::ng-deep p a`, both the `<a>` and `<p>` elements must be descendants of the component's host element.
9898

9999
They can come from the component's template or the views of its child components, but not elsewhere in the app.
100100

β€Žadev/src/content/guide/hydration.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ Providing a custom or a "noop" Zone.js implementation may lead to a different ti
142142

143143
## Errors
144144

145-
There are several hydration related errors you may encounter ranging from node mismatches to cases when the `ngSkipHydration` was used on an invalid host node. The most common error case that may occur is due to direct DOM manipulation using native APIs that results in hydration being unable to find or match the expected DOM tree structure on the client that was rendered by the server. The other case you may encounter this type of error was mentioned in the [Valid HTML structure](#valid-html-structure) section earlier. So, make sure the HTML in your templates are using valid structure, and you'll avoid that error case.
145+
There are several hydration related errors you may encounter ranging from node mismatches to cases when the `ngSkipHydration` was used on an invalid host node. The most common error case that may occur is due to direct DOM manipulation using native APIs that results in hydration being unable to find or match the expected DOM tree structure on the client that was rendered by the server. The other case you may encounter this type of error was mentioned in the [Valid HTML structure](#valid-html-structure) section earlier. So, make sure the HTML in your templates is using valid structure, and you'll avoid that error case.
146146

147147
For a full reference on hydration related errors, visit the [Errors Reference Guide](/errors).
148148

β€Žcontributing-docs/branches-and-versioning.mdβ€Ž

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,14 @@ major version.
102102

103103
Two additional target labels do not map to specific versions while still defining which branch to merge into.
104104

105-
| Label | Description |
106-
| ------------------ | ----------------------------------------------------- |
107-
| target: automation | A automated change made by the angular-robot account. |
108-
| target: feature | A change to be made in a feature branch. |
105+
| Label | Description |
106+
| ------------------ | ------------------------------------------------------ |
107+
| target: automation | An automated change made by the angular-robot account. |
108+
| target: feature | A change to be made in a feature branch. |
109109

110110
Changes made to a feature branch, outside of our typical branching and merging process utilize the
111111
`target: feature` branch. Additionally, the `target: automation` label, which is only able to be
112-
utilized by the `angular-robot` account targets only the branch defined within the Github UI.
112+
utilized by the `angular-robot` account targets only the branch defined within the GitHub UI.
113113

114114
### Pull request examples
115115

β€Žcontributing-docs/caretaking.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ pnpm ng-dev pr merge <pr number>
2626
Some directories in the Angular codebase have additional protections or rules. For example, code
2727
under `//packages/core/primitives` must be merged and synced into Google separately from other
2828
changes. Attempting to combine changes in `primitives` with other changes results in an error. This
29-
practices makes it significantly easier to rollback or revert changes in the event of a breakage or
29+
practice makes it significantly easier to rollback or revert changes in the event of a breakage or
3030
outage.
3131

3232
## PRs that require global presubmits

β€Žcontributing-docs/commit-message-guidelines.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Must be one of the following:
4545
| Type | Description |
4646
| ------------ | --------------------------------------------------------------------------------------------------- |
4747
| **build** | Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) |
48-
| **ci** | Changes to our CI configuration files and scripts (examples: Github Actions, SauceLabs) |
48+
| **ci** | Changes to our CI configuration files and scripts (examples: GitHub Actions, SauceLabs) |
4949
| **docs** | Documentation only changes |
5050
| **feat** | A new feature |
5151
| **fix** | A bug fix |

β€Žcontributing-docs/documentation-authoring.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ because they are _very_ common.
9494
- Use callouts for a brief aside that offers more context on a topic that's not strictly
9595
necessary to understanding the main content
9696
- Never put multiple callouts next to each other or in proximity (such as separated
97-
by one a line or two of text)
97+
by a line or two of text)
9898
- Never put a callout inside another element, such as a card or table cell
9999
- **Alerts**
100100
- Use sparingly to call attention to a very brief but relevant point

β€Žcontributing-docs/triage-and-labelling.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The owner of the component is then responsible for the detailed / component-leve
99
### Areas
1010

1111
The caretaker should be able to determine the _area_ for incoming issues.
12-
Most areas generally corresponds to a specific directory or set of directories in this repo. Some
12+
Most areas generally correspond to a specific directory or set of directories in this repo. Some
1313
areas are more cross-cutting (e.g. for performance or security). Apply all labels that make sense
1414
for an issue. Each `area: ` label on GitHub should have a description of what it's for.
1515

β€Žcontributing-docs/using-fixup-commits.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ However, amending an existing commit with the changes makes it difficult for the
5151
exactly what has changed since the last time they reviewed the Pull Request.
5252

5353
Here is where fixup commits come in handy.
54-
By addressing review feedback in fixup commits, you make it very straight forward for the reviewer
54+
By addressing review feedback in fixup commits, you make it very straightforward for the reviewer
5555
to see what are the new changes that need to be reviewed and verify that their earlier feedback has
5656
been addressed.
5757
This can save a lot of effort, especially on larger Pull Requests (where having to re-review _all_

0 commit comments

Comments
Β (0)