Skip to content

Commit 390139e

Browse files
kirjsmmalerba
authored andcommitted
docs: address comments (#58786)
PR Close #58786
1 parent 7ecaffc commit 390139e

File tree

3 files changed

+24
-16
lines changed

3 files changed

+24
-16
lines changed

.ng-dev/commit-message.mts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ export const commitMessage: CommitMessageConfig = {
77
maxLineLength: Infinity,
88
minBodyLength: 20,
99
minBodyLengthTypeExcludes: ['docs'],
10+
// If you update this, also update the docs.
11+
// https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md#scope
1012
scopes: [
1113
'animations',
1214
'bazel',

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ We have very precise rules over how our Git commit messages must be formatted:
217217
<type>(<scope>): <short summary>
218218
```
219219
220-
See [Commit Message Guidelines][commit-message-guidelines].
220+
See [Commit Message Guidelines][commit-message-guidelines] for details.
221221
222222
## <a name="cla"></a> Signing the CLA
223223

contributing-docs/commit-message-guidelines.md

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# Commit Message Format
22

3-
*This specification is inspired by and supersedes the [AngularJS commit message format][angularjs-commit-message-format].*
4-
53
We have very precise rules over how our Git commit messages must be formatted.
64
This format leads to **easier to read commit history**.
75

@@ -47,39 +45,48 @@ The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is opti
4745

4846
Must be one of the following:
4947

50-
* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
51-
* **ci**: Changes to our CI configuration files and scripts (examples: Github Actions, SauceLabs)
52-
* **docs**: Documentation only changes
53-
* **feat**: A new feature
54-
* **fix**: A bug fix
55-
* **perf**: A code change that improves performance
56-
* **refactor**: A code change that neither fixes a bug nor adds a feature
57-
* **test**: Adding missing tests or correcting existing tests
48+
| Type | Description |
49+
|--------------|-----------------------------------------------------------------------------------------------------|
50+
| **build** | Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) |
51+
| **ci** | Changes to our CI configuration files and scripts (examples: Github Actions, SauceLabs) |
52+
| **docs** | Documentation only changes |
53+
| **feat** | A new feature |
54+
| **fix** | A bug fix |
55+
| **perf** | A code change that improves performance |
56+
| **refactor** | A code change that neither fixes a bug nor adds a feature |
57+
| **test** | Adding missing tests or correcting existing tests |
5858

5959

60-
### Scope
60+
### <a name="scope"></a> Scope
6161
The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages).
6262

6363
The following is the list of supported scopes:
6464

6565
* `animations`
6666
* `bazel`
6767
* `benchpress`
68+
* `changelog`
6869
* `common`
6970
* `compiler`
7071
* `compiler-cli`
7172
* `core`
73+
* `dev-infra`
74+
* `devtools`
75+
* `docs-infra`
7276
* `elements`
7377
* `forms`
7478
* `http`
7579
* `language-service`
7680
* `localize`
81+
* `migrations`
82+
* `packaging`
7783
* `platform-browser`
7884
* `platform-browser-dynamic`
7985
* `platform-server`
80-
* `router`
86+
* `uter`
8187
* `service-worker`
8288
* `upgrade`
89+
* `ve`
8390
* `zone.js`
8491

8592
There are currently a few exceptions to the "use package name" rule:
@@ -118,7 +125,7 @@ You can include a comparison of the previous behavior with the new behavior in o
118125

119126
## <a name="commit-footer"></a>Commit Message Footer
120127

121-
The footer can contain information about breaking changes and deprecations and is also the place to reference GitHub issues, Jira tickets, and other PRs that this commit closes or is related to.
128+
The footer can contain information about breaking changes and deprecations and is also the place to reference GitHub issues and other PRs that this commit closes or is related to.
122129
For example:
123130

124131
```
@@ -141,11 +148,10 @@ DEPRECATED: <what is deprecated>
141148
Closes #<pr number>
142149
```
143150

144-
Breaking Change section should start with the phrase `BREAKING CHANGE: ` followed by a summary of the breaking change, a blank line, and a detailed description of the breaking change that also includes migration instructions.
151+
Breaking Change section should start with the phrase `BREAKING CHANGE: ` followed by a *brief* summary of the breaking change, a blank line, and a detailed description of the breaking change that also includes migration instructions.
145152

146153
Similarly, a Deprecation section should start with `DEPRECATED: ` followed by a short description of what is deprecated, a blank line, and a detailed description of the deprecation that also mentions the recommended update path.
147154

148-
149155
## Revert commits
150156

151157
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit.

0 commit comments

Comments
 (0)