test(core): add test validating that component destroy does not depend on the injector

dgp1130 · dgp1130 · commit 17f2628fc680 · 2026-03-27T17:07:34.000-07:00
While developing this feature, I attempted to inject a service during component destruction (to call `SharedStylesHost.prototype.removeHost`), however this broke some Material use cases which seem to destroy the injector before the component. Whether this constraint was intended or not, I believe we currently live in a world where component destruction cannot depend on its injection, so I'm enforcing this in a test to be clear about that constraint.

This is not intended to imply that this is a _good_ constraint or that we _want_ this to be the case, but it does represent the reality we currently exist in.
diff --git a/packages/core/test/acceptance/view_container_ref_spec.ts b/packages/core/test/acceptance/view_container_ref_spec.ts
@@ -732,6 +732,46 @@ describe('ViewContainerRef', () => {
     });
   });
 
+  describe('destroy', () => {
+    // NOTE: We may not necessarily _want_ this to be the case, but it does seem to be necessary
+    // for some amount of Angular code out there. We may want to consider lifting this constraint.
+    it('should not throw if the injector is destroyed before a view is removed', () => {
+      @Component({
+        template: 'View Content',
+        standalone: false,
+      })
+      class DynamicComponent {}
+
+      @Component({
+        template: '<ng-container #vcr></ng-container>',
+        standalone: false,
+      })
+      class App {
+        @ViewChild('vcr', {read: ViewContainerRef, static: true})
+        vcr!: ViewContainerRef;
+      }
+
+      TestBed.configureTestingModule({declarations: [App, DynamicComponent]});
+
+      const envInjector = createEnvironmentInjector([], TestBed.inject(EnvironmentInjector));
+      const fixture = TestBed.createComponent(App);
+      fixture.detectChanges();
+
+      const componentRef = fixture.componentInstance.vcr.createComponent(DynamicComponent, {
+        environmentInjector: envInjector,
+      });
+      fixture.detectChanges();
+
+      // Destroy the environment injector first
+      envInjector.destroy();
+
+      // Should be able to destroy the component afterwards.
+      expect(() => {
+        componentRef.destroy();
+      }).not.toThrow();
+    });
+  });
+
   describe('length', () => {
     it('should return the number of embedded views', () => {
       TestBed.configureTestingModule({declarations: [EmbeddedViewInsertionComp, VCRefDirective]});
