Skip to content

Commit 0beab21

Browse files
committed
refactor(core): add childSignalProp to ReactiveNodeKind
Add `childSignalProp` to `ReactiveNodeKind` in order to consolidate `ReactiveNodeKind` types and enable Client-Only Wiz to use it.
1 parent 2e4ed80 commit 0beab21

3 files changed

Lines changed: 4 additions & 10 deletions

File tree

devtools/projects/protocol/src/lib/messages.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,11 @@ import {
1717
Injector,
1818
Type,
1919
} from '@angular/core';
20+
import {ReactiveNodeKind} from '@angular/core/primitives/signals';
2021

2122
export interface DebugSignalGraphNode {
2223
id: string;
23-
kind:
24-
| 'signal'
25-
| 'computed'
26-
| 'effect'
27-
| 'template'
28-
| 'linkedSignal'
29-
| 'afterRenderEffectPhase'
30-
| 'childSignalProp' // Represents a signal passed as a prop to a child component in a CoW app
31-
| 'unknown';
24+
kind: ReactiveNodeKind;
3225
epoch: number;
3326
label?: string;
3427
preview: Descriptor;

goldens/public-api/core/primitives/signals/index.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ export interface ReactiveNode {
159159
}
160160

161161
// @public (undocumented)
162-
export type ReactiveNodeKind = 'signal' | 'computed' | 'effect' | 'template' | 'linkedSignal' | 'afterRenderEffectPhase' | 'unknown';
162+
export type ReactiveNodeKind = 'signal' | 'computed' | 'effect' | 'template' | 'linkedSignal' | 'afterRenderEffectPhase' | 'childSignalProp' | 'unknown';
163163

164164
// @public
165165
export function resetConsumerBeforeComputation(node: ReactiveNode): void;

packages/core/primitives/signals/src/graph.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export type ReactiveNodeKind =
9595
| 'template'
9696
| 'linkedSignal'
9797
| 'afterRenderEffectPhase'
98+
| 'childSignalProp' // Represents a signal passed as a prop to a child component in a CoW app
9899
| 'unknown';
99100

100101
/**

0 commit comments

Comments
 (0)