feat(platform-browser): Updates

ryan-bendel · ryan-bendel · commit 0b8d24e83b01 · 2025-08-19T14:14:37.000+01:00
Updates after suggestion from team
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -200,7 +200,6 @@
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
       "PLATFORM_INITIALIZER",
-      "PLATFORM_SERVER_ID",
       "PREORDER_HOOK_FLAGS",
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
@@ -648,7 +647,6 @@
       "isNonAnimatableStyle",
       "isNotFound",
       "isObserver",
-      "isPlatformServer",
       "isPositive",
       "isPromise",
       "isRefreshingViews",
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -30,7 +30,6 @@
       "NAMESPACE_URIS",
       "NoneEncapsulationDomRenderer",
       "PLATFORM_BROWSER_ID",
-      "PLATFORM_SERVER_ID",
       "REMOVE_STYLES_ON_COMPONENT_DESTROY",
       "REMOVE_STYLES_ON_COMPONENT_DESTROY_DEFAULT",
       "ShadowDomRenderer",
@@ -49,7 +48,6 @@
       "getBaseElementHref",
       "getDOM",
       "initDomAdapter",
-      "isPlatformServer",
       "isTemplateNode",
       "parseCookieValue",
       "relativePath",
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -205,7 +205,6 @@
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
       "PLATFORM_INITIALIZER",
-      "PLATFORM_SERVER_ID",
       "PREORDER_HOOK_FLAGS",
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
@@ -745,7 +744,6 @@
       "isObserver",
       "isOptionsObj",
       "isPOJO",
-      "isPlatformServer",
       "isPositive",
       "isPresent",
       "isPromise",
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -202,7 +202,6 @@
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
       "PLATFORM_INITIALIZER",
-      "PLATFORM_SERVER_ID",
       "PREORDER_HOOK_FLAGS",
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
@@ -745,7 +744,6 @@
       "isObserver",
       "isOptionsObj",
       "isPOJO",
-      "isPlatformServer",
       "isPositive",
       "isPresent",
       "isPromise",
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -176,7 +176,6 @@
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
       "PLATFORM_INITIALIZER",
-      "PLATFORM_SERVER_ID",
       "PREORDER_HOOK_FLAGS",
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
@@ -602,7 +601,6 @@
       "isLView",
       "isNotFound",
       "isObserver",
-      "isPlatformServer",
       "isPositive",
       "isPromise",
       "isPromise2",
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -214,7 +214,6 @@
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
       "PLATFORM_INITIALIZER",
-      "PLATFORM_SERVER_ID",
       "PREORDER_HOOK_FLAGS",
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
@@ -840,7 +839,6 @@
       "isObservable",
       "isObserver",
       "isPOJO",
-      "isPlatformServer",
       "isPositive",
       "isPromise",
       "isPromise2",
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -147,7 +147,6 @@
       "PLATFORM_DESTROY_LISTENERS",
       "PLATFORM_ID",
       "PLATFORM_INITIALIZER",
-      "PLATFORM_SERVER_ID",
       "PREORDER_HOOK_FLAGS",
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
@@ -482,7 +481,6 @@
       "isLView",
       "isNotFound",
       "isObserver",
-      "isPlatformServer",
       "isPositive",
       "isPromise",
       "isRefreshingViews",
diff --git a/packages/platform-browser/src/dom/shared_styles_host.ts b/packages/platform-browser/src/dom/shared_styles_host.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {DOCUMENT, isPlatformServer} from '@angular/common';
+import {DOCUMENT} from '@angular/common';
 import {
   APP_ID,
   CSP_NONCE,
@@ -114,6 +114,10 @@ export class SharedStylesHost implements OnDestroy {
    * External styles typically originate from the `ɵɵExternalStylesFeature` of a rendered component.
    */
   private readonly external = new Map<string /** URL */, UsageRecord<HTMLLinkElement>>();
+
+  /**
+   * Set of host DOM nodes that will have styles attached.
+   */
   private readonly hosts = new Set<Node>();
   private readonly shadowRoots: Node[] = [];
 
@@ -123,7 +127,7 @@ export class SharedStylesHost implements OnDestroy {
     @Inject(CSP_NONCE) @Optional() private readonly nonce?: string | null,
     // Cannot remove it due to backward compatibility
     // (it seems some TGP targets might be calling this constructor directly).
-    @Inject(PLATFORM_ID) private readonly platformId: object = {},
+    @Inject(PLATFORM_ID) platformId: object = {},
   ) {
     addServerStyles(doc, appId, this.inline, this.external);
     this.hosts.add(doc.head);
@@ -236,9 +240,9 @@ export class SharedStylesHost implements OnDestroy {
     if (this.nonce) {
       element.setAttribute('nonce', this.nonce);
     }
-    // The `ng-app-id` attribute is used on the server to identify which styles were
-    // created by the server renderer.
-    if (isPlatformServer(this.platformId) && host === this.doc.head) {
+
+    // Add application identifier when on the server to support client-side reuse
+    if (typeof ngServerMode !== 'undefined' && ngServerMode && host === this.doc.head) {
       element.setAttribute(APP_ID_ATTRIBUTE_NAME, this.appId);
     }
     host.appendChild(element);
