Clarified errormessage of checkBoost

PKEuS · PKEuS · commit 3b5dabdb1430 · 2012-08-02T02:40:08.000-07:00
diff --git a/lib/checkboost.cpp b/lib/checkboost.cpp
@@ -51,6 +51,6 @@ void CheckBoost::checkBoostForeachModification()
 void CheckBoost::boostForeachError(const Token *tok)
 {
     reportError(tok, Severity::error, "boostForeachError",
-                "BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container."
+                "BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside."
                );
 }
diff --git a/test/testboost.cpp b/test/testboost.cpp
@@ -61,31 +61,31 @@ class TestBoost : public TestFixture {
               "        data.push_back(123);\n"
               "    }\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
 
         check("void f() {\n"
               "    set<int> data;\n"
               "    BOOST_FOREACH(int i, data) {\n"
               "        data.insert(123);\n"
               "    }\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
 
         check("void f() {\n"
               "    set<int> data;\n"
               "    BOOST_FOREACH(const int &i, data) {\n"
               "        data.erase(123);\n"
               "    }\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
 
         // Check single line usage
         check("void f() {\n"
               "    set<int> data;\n"
               "    BOOST_FOREACH(const int &i, data)\n"
               "        data.clear();\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
 
         // Container returned as result of a function -> Be quiet
         check("void f() {\n"

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,6 @@ void CheckBoost::checkBoostForeachModification()`
`51`	`51`	`void CheckBoost::boostForeachError(const Token *tok)`
`52`	`52`	`{`
`53`	`53`	`reportError(tok, Severity::error, "boostForeachError",`
`54`		`- "BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container."`
	`54`	`+ "BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside."`
`55`	`55`	`);`
`56`	`56`	`}`