/*

* Cppcheck - A tool for static C/C++ code analysis

* Copyright (C) 2007-2019 Cppcheck team.

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 3 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

#include "checkstl.h"

#include "settings.h"

#include "standards.h"

#include "testsuite.h"

#include "tokenize.h"

#include <cstddef>

#include <string>

class TestStl : public TestFixture {

public:

TestStl() : TestFixture("TestStl") {

}

private:

Settings settings;

void run() OVERRIDE {

settings.addEnabled("warning");

settings.addEnabled("style");

settings.addEnabled("performance");

LOAD_LIB_2(settings.library, "std.cfg");

TEST_CASE(outOfBounds);

TEST_CASE(outOfBoundsIndexExpression);

TEST_CASE(iterator1);

TEST_CASE(iterator2);

TEST_CASE(iterator3);

TEST_CASE(iterator4);

TEST_CASE(iterator5);

TEST_CASE(iterator6);

TEST_CASE(iterator7);

TEST_CASE(iterator8);

TEST_CASE(iterator9);

TEST_CASE(iterator10);

TEST_CASE(iterator11);

TEST_CASE(iterator12);

TEST_CASE(iterator13);

TEST_CASE(iterator14); // #8191

TEST_CASE(iterator15); // #8341

TEST_CASE(iterator16);

TEST_CASE(iterator17);

TEST_CASE(iterator18);

TEST_CASE(iterator19);

TEST_CASE(iterator20);

TEST_CASE(iterator21);

TEST_CASE(iteratorExpression);

TEST_CASE(iteratorSameExpression);

TEST_CASE(dereference);

TEST_CASE(dereference_break); // #3644 - handle "break"

TEST_CASE(dereference_member);

TEST_CASE(STLSize);

TEST_CASE(STLSizeNoErr);

TEST_CASE(negativeIndex);

TEST_CASE(erase1);

TEST_CASE(erase2);

TEST_CASE(erase3);

TEST_CASE(erase4);

TEST_CASE(erase5);

TEST_CASE(erase6);

TEST_CASE(eraseBreak);

TEST_CASE(eraseContinue);

TEST_CASE(eraseReturn1);

TEST_CASE(eraseReturn2);

TEST_CASE(eraseReturn3);

TEST_CASE(eraseGoto);

TEST_CASE(eraseAssign1);

TEST_CASE(eraseAssign2);

TEST_CASE(eraseAssign3);

TEST_CASE(eraseAssign4);

TEST_CASE(eraseAssignByFunctionCall);

TEST_CASE(eraseErase);

TEST_CASE(eraseByValue);

TEST_CASE(eraseIf);

TEST_CASE(eraseOnVector);

TEST_CASE(pushback1);

TEST_CASE(pushback2);

TEST_CASE(pushback3);

TEST_CASE(pushback4);

TEST_CASE(pushback5);

TEST_CASE(pushback6);

TEST_CASE(pushback7);

TEST_CASE(pushback8);

TEST_CASE(pushback9);

TEST_CASE(pushback10);

TEST_CASE(pushback11);

TEST_CASE(pushback12);

TEST_CASE(pushback13);

TEST_CASE(insert1);

TEST_CASE(insert2);

TEST_CASE(stlBoundaries1);

TEST_CASE(stlBoundaries2);

TEST_CASE(stlBoundaries3);

TEST_CASE(stlBoundaries4); // #4364

TEST_CASE(stlBoundaries5); // #4352

TEST_CASE(stlBoundaries6); // #7106

// if (str.find("ab"))

TEST_CASE(if_find);

TEST_CASE(if_str_find);

TEST_CASE(size1);

TEST_CASE(size2);

TEST_CASE(size3);

TEST_CASE(size4); // #2652 - don't warn about vector/deque

// Redundant conditions..

// if (ints.find(123) != ints.end()) ints.remove(123);

TEST_CASE(redundantCondition1);

// missing inner comparison when incrementing iterator inside loop

TEST_CASE(missingInnerComparison1);

TEST_CASE(missingInnerComparison2); // no FP when there is comparison

TEST_CASE(missingInnerComparison3); // no FP when there is iterator shadowing

TEST_CASE(missingInnerComparison4); // no FP when "break;" is used

TEST_CASE(missingInnerComparison5); // Ticket #2154 - FP

TEST_CASE(missingInnerComparison6); // #2643 - 'it=foo.insert(++it,0);'

// catch common problems when using the string::c_str() function

TEST_CASE(cstr);

TEST_CASE(uselessCalls);

TEST_CASE(stabilityOfChecks); // #4684 cppcheck crash in template function call

TEST_CASE(dereferenceInvalidIterator);

TEST_CASE(dereferenceInvalidIterator2); // #6572

TEST_CASE(dereference_auto);

TEST_CASE(loopAlgoElementAssign);

TEST_CASE(loopAlgoAccumulateAssign);

TEST_CASE(loopAlgoContainerInsert);

TEST_CASE(loopAlgoIncrement);

TEST_CASE(loopAlgoConditional);

TEST_CASE(loopAlgoMinMax);

TEST_CASE(invalidContainer);

TEST_CASE(findInsert);

}

void check(const char code[], const bool inconclusive=false, const Standards::cppstd_t cppstandard=Standards::CPPLatest) {

// Clear the error buffer..

errout.str("");

settings.inconclusive = inconclusive;

settings.standards.cpp = cppstandard;

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

CheckStl checkStl(&tokenizer, &settings, this);

tokenizer.tokenize(istr, "test.cpp");

checkStl.runChecks(&tokenizer, &settings, this);

}

void check(const std::string &code, const bool inconclusive=false) {

check(code.c_str(), inconclusive);

}

void checkNormal(const char code[]) {

// Clear the error buffer..

errout.str("");

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, "test.cpp");

// Check..

CheckStl checkStl(&tokenizer, &settings, this);

checkStl.runChecks(&tokenizer, &settings, this);

}

void outOfBounds() {

setMultiline();

checkNormal("void f() {\n"

" std::string s;\n"

" s[10] = 1;\n"

"}");

ASSERT_EQUALS("test.cpp:3:error:Out of bounds access in expression 's[10]' because 's' is empty.\n", errout.str());

checkNormal("void f() {\n"

" std::string s = \"abcd\";\n"

" s[10] = 1;\n"

"}");

ASSERT_EQUALS("test.cpp:3:error:Out of bounds access in 's[10]', if 's' size is 4 and '10' is 10\n", errout.str());

checkNormal("void f(std::vector<int> v) {\n"

" v.front();\n"

" if (v.empty()) {}\n"

"}\n");

ASSERT_EQUALS("test.cpp:2:warning:Either the condition 'v.empty()' is redundant or expression 'v.front()' cause access out of bounds.\n"

"test.cpp:3:note:condition 'v.empty()'\n"

"test.cpp:2:note:Access out of bounds\n", errout.str());

checkNormal("void f(std::vector<int> v) {\n"

" if (v.size() == 3) {}\n"

" v[16] = 0;\n"

"}\n");

ASSERT_EQUALS("test.cpp:3:warning:Either the condition 'v.size()==3' is redundant or v size can be 3. Expression 'v[16]' cause access out of bounds.\n"

"test.cpp:2:note:condition 'v.size()==3'\n"

"test.cpp:3:note:Access out of bounds\n", errout.str());

checkNormal("void f(std::vector<int> v) {\n"

" int i = 16;\n"

" if (v.size() == 3) {\n"

" v[i] = 0;\n"

" }\n"

"}\n");

ASSERT_EQUALS("test.cpp:4:warning:Either the condition 'v.size()==3' is redundant or v size can be 3. Expression 'v[i]' cause access out of bounds.\n"

"test.cpp:3:note:condition 'v.size()==3'\n"

"test.cpp:4:note:Access out of bounds\n", errout.str());

checkNormal("void f(std::vector<int> v, int i) {\n"

" if (v.size() == 3 || i == 16) {}\n"

" v[i] = 0;\n"

"}\n");

ASSERT_EQUALS("", errout.str());

checkNormal("void f(std::map<int,int> x) {\n"

" if (x.empty()) { x[1] = 2; }\n"

"}\n");

ASSERT_EQUALS("", errout.str());

checkNormal("void f(std::string s) {\n"

" if (s.size() == 1) {\n"

" s[2] = 0;\n"

" }\n"

"}\n");

ASSERT_EQUALS("test.cpp:3:warning:Either the condition 's.size()==1' is redundant or s size can be 1. Expression 's[2]' cause access out of bounds.\n"

"test.cpp:2:note:condition 's.size()==1'\n"

"test.cpp:3:note:Access out of bounds\n", errout.str());

// Do not crash

checkNormal("void a() {\n"

" std::string b[];\n"

" for (auto c : b)\n"

" c.data();\n"

"}\n");

ASSERT_EQUALS("", errout.str());

checkNormal("std::string f(std::string x) {\n"

" if (x.empty()) return {};\n"

" x[0];\n"

"}\n");

ASSERT_EQUALS("", errout.str());

checkNormal("std::string f(std::string x) {\n"

" if (x.empty()) return std::string{};\n"

" x[0];\n"

"}\n");

ASSERT_EQUALS("", errout.str());

checkNormal("void f() {\n"

" std::string s;\n"

" x = s.begin() + 1;\n"

"}\n");

ASSERT_EQUALS("test.cpp:3:error:Out of bounds access in expression 's.begin()+1' because 's' is empty.\n", errout.str());

checkNormal("void f(int x) {\n"

" std::string s;\n"

" x = s.begin() + x;\n"

"}\n");

ASSERT_EQUALS("test.cpp:3:error:Out of bounds access in expression 's.begin()+x' because 's' is empty and 'x' may be non-zero.\n", errout.str());

checkNormal("char fstr1(){const std::string s = \"<a><b>\"; return s[42]; }\n"

"wchar_t fwstr1(){const std::wstring s = L\"<a><b>\"; return s[42]; }\n");

ASSERT_EQUALS("test.cpp:1:error:Out of bounds access in 's[42]', if 's' size is 6 and '42' is 42\n"

"test.cpp:2:error:Out of bounds access in 's[42]', if 's' size is 6 and '42' is 42\n", errout.str());

checkNormal("char fstr1(){const std::string s = \"<a><b>\"; return s[1]; }\n"

"wchar_t fwstr1(){const std::wstring s = L\"<a><b>\"; return s[1]; }\n");

ASSERT_EQUALS("", errout.str());

checkNormal("int f() {\n"

" std::vector<int> v;\n"

" std::vector<int> * pv = &v;\n"

" return (*pv)[42];\n"

"}\n");

ASSERT_EQUALS("test.cpp:4:error:Out of bounds access in expression '(*pv)[42]' because '*pv' is empty.\n", errout.str());

checkNormal("void f() {\n"

" std::string s;\n"

" ++abc[s];\n"

"}");

ASSERT_EQUALS("", errout.str());

// # 9274

checkNormal("char f(bool b) {\n"

" const std::string s = \"<a><b>\";\n"

" int x = 6;\n"

" if(b) ++x;\n"

" return s[x];\n"

"}\n");

ASSERT_EQUALS("test.cpp:5:error:Out of bounds access in 's[x]', if 's' size is 6 and 'x' is 6\n", errout.str());

checkNormal("void f() {\n"

" static const int N = 4;\n"

" std::array<int, N> x;\n"

" x[0] = 0;\n"

"}\n");

ASSERT_EQUALS("", errout.str());

}

void outOfBoundsIndexExpression() {

setMultiline();

checkNormal("void f(std::string s) {\n"

" s[s.size()] = 1;\n"

"}");

ASSERT_EQUALS("test.cpp:2:error:Out of bounds access of s, index 's.size()' is out of bounds.\n", errout.str());

checkNormal("void f(std::string s) {\n"

" s[s.size()+1] = 1;\n"

"}");

ASSERT_EQUALS("test.cpp:2:error:Out of bounds access of s, index 's.size()+1' is out of bounds.\n", errout.str());

checkNormal("void f(std::string s) {\n"

" s[1+s.size()] = 1;\n"

"}");

ASSERT_EQUALS("test.cpp:2:error:Out of bounds access of s, index '1+s.size()' is out of bounds.\n", errout.str());

checkNormal("void f(std::string s) {\n"

" s[x*s.size()] = 1;\n"

"}");

ASSERT_EQUALS("test.cpp:2:error:Out of bounds access of s, index 'x*s.size()' is out of bounds.\n", errout.str());

}

void iterator1() {

check("void f()\n"

"{\n"

" list<int> l1;\n"

" list<int> l2;\n"

" for (list<int>::iterator it = l1.begin(); it != l2.end(); ++it)\n"

" { }\n"

"}");

ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:5]: (error) Same iterator is used with different containers 'l1' and 'l2'.\n", errout.str());

check("void f()\n"

"{\n"

" list<int> l1;\n"

" list<int> l2;\n"

" for (list<int>::iterator it = l1.begin(); l2.end() != it; ++it)\n"

" { }\n"

"}");

ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:5]: (error) Same iterator is used with different containers 'l2' and 'l1'.\n", errout.str());

check("struct C { std::list<int> l1; void func(); };\n"

"void C::func() {\n"

" std::list<int>::iterator it;\n"

" for (it = l1.begin(); it != l1.end(); ++it) { }\n"

" C c;\n"

" for (it = c.l1.begin(); it != c.l1.end(); ++it) { }\n"

"}");

ASSERT_EQUALS("", errout.str());

// Same check with reverse iterator

check("void f()\n"

"{\n"

" list<int> l1;\n"

" list<int> l2;\n"

" for (list<int>::const_reverse_iterator it = l1.rbegin(); it != l2.rend(); ++it)\n"

" { }\n"

"}");

ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:5]: (error) Same iterator is used with different containers 'l1' and 'l2'.\n", errout.str());

}

void iterator2() {

check("void foo()\n"

"{\n"

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" while (it != l2.end())\n"

" {\n"

" ++it;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:6] -> [test.cpp:5]: (error) Same iterator is used with different containers 'l1' and 'l2'.\n", errout.str());

check("void foo()\n"

"{\n"

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" while (l2.end() != it)\n"

" {\n"

" ++it;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:6] -> [test.cpp:5]: (error) Same iterator is used with different containers 'l2' and 'l1'.\n", errout.str());

}

void iterator3() {

check("void foo()\n"

"{\n"

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" l2.insert(it, 0);\n"

"}");

ASSERT_EQUALS("[test.cpp:6]: (error) Same iterator is used with different containers 'l1' and 'l2'.\n", errout.str());

check("void foo() {\n" // #5803

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" l2.insert(it, l1.end());\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n" // #7658

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" list<int>::iterator end = l1.end();\n"

" l2.insert(it, end);\n"

"}");

ASSERT_EQUALS("", errout.str());

// only warn for insert when there are preciself 2 arguments.

check("void foo() {\n"

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" l2.insert(it);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" list<int> l1;\n"

" list<int> l2;\n"

" list<int>::iterator it = l1.begin();\n"

" l2.insert(it,0,1);\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator4() {

check("void foo(std::vector<std::string> &test)\n"

"{\n"

" std::set<int> result;\n"

" for (std::vector<std::string>::const_iterator cit = test.begin();\n"

" cit != test.end();\n"

" ++cit)\n"

" {\n"

" result.insert(cit->size());\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator5() {

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::find(ints1.begin(), ints2.end(), 22);\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Iterators of different containers are used together.\n", errout.str());

}

void iterator6() {

// Ticket #1357

check("void foo(const std::set<int> &ints1)\n"

"{\n"

" std::set<int> ints2;\n"

" std::set<int>::iterator it1 = ints1.begin();\n"

" std::set<int>::iterator it2 = ints1.end();\n"

" ints2.insert(it1, it2);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(const std::set<int> &ints1)\n"

"{\n"

" std::set<int> ints2;\n"

" std::set<int>::iterator it1 = ints1.begin();\n"

" std::set<int>::iterator it2 = ints2.end();\n"

" ints2.insert(it1, it2);\n"

"}");

TODO_ASSERT_EQUALS("[test.cpp:6]: (error) Iterators of different containers are used together.\n", "", errout.str());

}

void iterator7() {

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::inplace_merge(ints1.begin(), std::advance(ints1.rbegin(), 5), ints2.end());\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Iterators of different containers are used together.\n", errout.str());

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::inplace_merge(ints1.begin(), std::advance(ints2.rbegin(), 5), ints1.end());\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator8() {

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::find_first_of(ints1.begin(), ints2.end(), ints1.begin(), ints1.end());\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Iterators of different containers are used together.\n", errout.str());

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::find_first_of(ints1.begin(), ints1.end(), ints2.begin(), ints1.end());\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Iterators of different containers are used together.\n", errout.str());

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::find_first_of(foo.bar.begin(), foo.bar.end()-6, ints2.begin(), ints1.end());\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Iterators of different containers are used together.\n", errout.str());

check("void foo()\n"

"{\n"

" std::vector<int> ints1;\n"

" std::vector<int> ints2;\n"

" std::vector<int>::iterator it = std::find_first_of(ints1.begin(), ints1.end(), ints2.begin(), ints2.end());\n"

"}");

ASSERT_EQUALS("", errout.str());

// #6839

check("void f(const std::wstring& a, const std::wstring& b) {\n"

" const std::string tp1 = std::string(a.begin(), b.end());\n"

" const std::wstring tp2 = std::string(b.begin(), a.end());\n"

" const std::u16string tp3(a.begin(), b.end());\n"

" const std::u32string tp4(b.begin(), a.end());\n"

" const std::string fp1 = std::string(a.begin(), a.end());\n"

" const std::string tp2(a.begin(), a.end());\n"

"}");

ASSERT_EQUALS(// TODO "[test.cpp:2]: (error) Iterators of different containers are used together.\n"

// TODO "[test.cpp:3]: (error) Iterators of different containers are used together.\n"

"[test.cpp:4]: (error) Iterators of different containers are used together.\n"

"[test.cpp:5]: (error) Iterators of different containers are used together.\n", errout.str());

}

void iterator9() {

// Ticket #1600

check("void foo(std::vector<int> &r)\n"

"{\n"

" std::vector<int>::iterator aI = r.begin();\n"

" while(aI != r.end())\n"

" {\n"

" if (*aI == 0)\n"

" {\n"

" r.insert(aI, 42);\n"

" return;\n"

" }\n"

" ++aI;\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

// Ticket #2481

check("void foo(std::vector<int> &r)\n"

"{\n"

" std::vector<int>::iterator aI = r.begin();\n"

" while(aI != r.end())\n"

" {\n"

" if (*aI == 0)\n"

" {\n"

" r.insert(aI, 42);\n"

" break;\n"

" }\n"

" ++aI;\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

// Execution path checking..

check("void foo(std::vector<int> &r, int c)\n"

"{\n"

" std::vector<int>::iterator aI = r.begin();\n"

" while(aI != r.end())\n"

" {\n"

" if (*aI == 0)\n"

" {\n"

" r.insert(aI, 42);\n"

" if (c)\n"

" {\n"

" return;\n"

" }\n"

" }\n"

" ++aI;\n"

" }\n"

"}");

TODO_ASSERT_EQUALS("[test.cpp:14] (error) After insert(), the iterator 'aI' may be invalid.", "", errout.str());

}

void iterator10() {

// Ticket #1679

check("void foo()\n"

"{\n"

" std::set<int> s1;\n"

" std::set<int> s2;\n"

" for (std::set<int>::iterator it = s1.begin(); it != s1.end(); ++it)\n"

" {\n"

" if (true) { }\n"

" if (it != s2.end()) continue;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:8] -> [test.cpp:5]: (error) Same iterator is used with different containers 's1' and 's2'.\n", errout.str());

}

void iterator11() {

// Ticket #3433

check("int main() {\n"

" map<int, int> myMap;\n"

" vector<string> myVector;\n"

" for(vector<int>::iterator x = myVector.begin(); x != myVector.end(); x++)\n"

" myMap.erase(*x);\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator12() {

// Ticket #3201

check("void f() {\n"

" std::map<int, int> map1;\n"

" std::map<int, int> map2;\n"

" std::map<int, int>::const_iterator it = map1.find(123);\n"

" if (it == map2.end()) { }"

"}");

ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:4]: (error) Same iterator is used with different containers 'map1' and 'map2'.\n", errout.str());

check("void f() {\n"

" std::map<int, int> map1;\n"

" std::map<int, int> map2;\n"

" std::map<int, int>::const_iterator it = map1.find(123);\n"

" if (map2.end() == it) { }"

"}");

ASSERT_EQUALS("[test.cpp:5] -> [test.cpp:4]: (error) Same iterator is used with different containers 'map2' and 'map1'.\n", errout.str());

check("void f(std::string &s) {\n"

" int pos = s.find(x);\n"

" s.erase(pos);\n"

" s.erase(pos);\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator13() {

check("void f() {\n"

" std::vector<int> a;\n"

" std::vector<int> t;\n"

" std::vector<int>::const_iterator it;\n"

" it = a.begin();\n"

" while (it!=a.end())\n"

" ++it;\n"

" it = t.begin();\n"

" while (it!=a.end())\n"

" ++it;\n"

"}");

ASSERT_EQUALS("[test.cpp:9] -> [test.cpp:8]: (error) Same iterator is used with different containers 't' and 'a'.\n", errout.str());

// #4062

check("void f() {\n"

" std::vector<int> a;\n"

" std::vector<int> t;\n"

" std::vector<int>::const_iterator it;\n"

" it = a.begin();\n"

" while (it!=a.end())\n"

" v++it;\n"

" it = t.begin();\n"

" while (it!=t.end())\n"

" ++it;\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void f() {\n"

" std::vector<int> a;\n"

" std::vector<int> t;\n"

" std::vector<int>::const_iterator it;\n"

" if(z)\n"

" it = a.begin();\n"

" else\n"

" it = t.begin();\n"

" while (z && it!=a.end())\n"

" v++it;\n"

" while (!z && it!=t.end())\n"

" v++it;\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator14() {

check("void f() {\n"

" std::map<int,Foo> x;\n"

" std::map<int,Foo>::const_iterator it;\n"

" for (it = x.find(0)->second.begin(); it != x.find(0)->second.end(); ++it) {}\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator15() {

check("void f(C1* x, std::list<int> a) {\n"

" std::list<int>::iterator pos = a.begin();\n"

" for(pos = x[0]->plist.begin(); pos != x[0]->plist.end(); ++pos) {}\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void iterator16() {

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l2.end();\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:7] -> [test.cpp:5] -> [test.cpp:6]: (error) Comparison of iterators from containers 'l1' and 'l2'.\n", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.end();\n"

" std::list<int>::iterator it2 = l2.begin();\n"

" while (it2 != it1)\n"

" {\n"

" ++it2;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:7] -> [test.cpp:6] -> [test.cpp:5]: (error) Comparison of iterators from containers 'l2' and 'l1'.\n", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it2 = l2.end();\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:7] -> [test.cpp:6] -> [test.cpp:5]: (error) Comparison of iterators from containers 'l1' and 'l2'.\n", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2(10, 4);\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l2.find(4);\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:7] -> [test.cpp:6] -> [test.cpp:5]: (error) Comparison of iterators from containers 'l1' and 'l2'.\n", errout.str());

}

void iterator17() {

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" { it2 = l2.end(); }\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:8] -> [test.cpp:5] -> [test.cpp:7]: (error) Comparison of iterators from containers 'l1' and 'l2'.\n", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

" it2 = l2.end();\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" it1 = l2.end();\n"

" it1 = l1.end();\n"

" if (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" { it2 = l2.end(); }\n"

" it2 = l1.end();\n"

" { it2 = l2.end(); }\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:10] -> [test.cpp:5] -> [test.cpp:9]: (error) Comparison of iterators from containers 'l1' and 'l2'.\n", errout.str());

}

void iterator18() {

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" while (++it1 != --it2)\n"

" {\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" while (it1++ != --it2)\n"

" {\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l1.end();\n"

" if (--it2 > it1++)\n"

" {\n"

" }\n"

"}");

TODO_ASSERT_EQUALS("", "[test.cpp:7]: (error) Dangerous comparison using operator< on iterator.\n", errout.str());

}

void iterator19() {

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" {\n"

" std::list<int> l1;\n"

" if (it1 != l1.end())\n"

" {\n"

" }\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:7] -> [test.cpp:4]: (error) Same iterator is used with containers 'l1' that are defined in different scopes.\n", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" {\n"

" std::list<int> l1;\n"

" if (l1.end() > it1)\n"

" {\n"

" }\n"

" }\n"

"}");

TODO_ASSERT_EQUALS("[test.cpp:7] -> [test.cpp:4]: (error) Same iterator is used with containers 'l1' that are defined in different scopes.\n",

"[test.cpp:7] -> [test.cpp:4]: (error) Same iterator is used with containers 'l1' that are defined in different scopes.\n[test.cpp:7]: (error) Dangerous comparison using operator< on iterator.\n",

errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" {\n"

" std::list<int> l1;\n"

" std::list<int>::iterator it2 = l1.begin();\n"

" if (it1 != it2)\n"

" {\n"

" }\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:8] -> [test.cpp:4] -> [test.cpp:7]: (error) Comparison of iterators from containers 'l1' that are defined in different scopes.\n", errout.str());

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" {\n"

" std::list<int> l1;\n"

" std::list<int>::iterator it2 = l1.begin();\n"

" if (it2 != it1)\n"

" {\n"

" }\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:8] -> [test.cpp:4] -> [test.cpp:7]: (error) Comparison of iterators from containers 'l1' that are defined in different scopes.\n", errout.str());

}

void iterator20() {

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l2.begin();\n"

" it1 = it2;\n"

" while (it1 != l1.end())\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

TODO_ASSERT_EQUALS("[test.cpp:8] -> [test.cpp:7]: (error) Same iterator is used with different containers 'l2' and 'l1'.\n", "", errout.str());

check("std::list<int> l3;\n"

"std::list<int>::iterator bar()\n"

"{\n"

" return l3.end();\n"

"}\n"

"void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.begin();\n"

" std::list<int>::iterator it2 = l2.begin();\n"

" it1 = bar();\n"

" while (it1 != it2)\n"

" {\n"

" ++it1;\n"

" }\n"

"}");

TODO_ASSERT_EQUALS("[test.cpp:13] -> [test.cpp:10] -> [test.cpp:11]: (error) Comparison of iterators from containers 'l1' and 'l2'.\n", "", errout.str());

}

void iterator21() {

check("void foo()\n"

"{\n"

" std::list<int> l1;\n"

" std::list<int> l2;\n"

" std::list<int>::iterator it1 = l1.end();\n"

" std::list<int>::iterator it2 = l2.begin();\n"

" if (it1 != it2)\n"

" {\n"