Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: danpaquin/coinbasepro-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: andyfarthing/coinbasepro-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 3 contributors

Commits on Jul 28, 2019

  1. Fix creation of stop orders

    A 'stop' isn't an actual order type but is actually a special flavour of
    a limit order. The 'stop' and 'stop_price' params need to be set.
    
    There are 2 stop types:
    1. loss (triggers at or below the stop price) -> this has to be a sell
    order to be valid (the Coinbase Pro will respond with an error
    otherwise)
    2. entry (trigger at or above the stop price) -> has to be a buy
    
    Modified existing and added new test.
    JonasSteur committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    735aeb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Merge pull request #1 from JonasSteur/fix-creation-of-stop-orders

    Fix creation of stop orders
    andyfarthing authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    f260d00 View commit details
    Browse the repository at this point in the history
  2. Allow limit price to be set for stop orders

    Andy Farthing committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    d1fcf0e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Add get profile support

    Andy Farthing committed May 18, 2020
    Configuration menu
    Copy the full SHA
    e4ac6c5 View commit details
    Browse the repository at this point in the history
  2. Fix incorrect URL

    Andy Farthing committed May 18, 2020
    Configuration menu
    Copy the full SHA
    d5ac683 View commit details
    Browse the repository at this point in the history
Loading