Skip to content

Commit c1d6425

Browse files
committed
Jetcaster: Decouple HomeScreen from WindowSizeClass
Refactored HomeScreen to accept a simple boolean 'isHomeAppBarExpanded' instead of the full WindowSizeClass object. This simplifies the API and removes the need for a mock WindowSizeClass in previews.
1 parent 65960e2 commit c1d6425

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

  • Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home

Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ private fun HomeScreenReady(
252252
directive = navigator.scaffoldDirective,
253253
mainPane = {
254254
HomeScreen(
255-
windowSizeClass = windowSizeClass,
255+
isHomeAppBarExpanded = windowSizeClass.isCompact,
256256
isLoading = uiState.isLoading,
257257
featuredPodcasts = uiState.featuredPodcasts,
258258
homeCategories = uiState.homeCategories,
@@ -362,7 +362,7 @@ private fun HomeScreenBackground(modifier: Modifier = Modifier, content: @Compos
362362

363363
@Composable
364364
private fun HomeScreen(
365-
windowSizeClass: WindowSizeClass,
365+
isHomeAppBarExpanded: Boolean,
366366
isLoading: Boolean,
367367
featuredPodcasts: ImmutableList<PodcastInfo>,
368368
selectedHomeCategory: HomeCategory,
@@ -391,7 +391,7 @@ private fun HomeScreen(
391391
topBar = {
392392
Column {
393393
HomeAppBar(
394-
isExpanded = windowSizeClass.isCompact,
394+
isExpanded = isHomeAppBarExpanded,
395395
modifier = Modifier.fillMaxWidth(),
396396
)
397397
if (isLoading) {
@@ -749,14 +749,12 @@ private fun HomeAppBarPreview() {
749749
}
750750
}
751751

752-
private val CompactWindowSizeClass = WindowSizeClass.BREAKPOINTS_V1.computeWindowSizeClass(360f, 780f)
753-
754752
@DevicePreviews
755753
@Composable
756754
private fun PreviewHome() {
757755
JetcasterTheme {
758756
HomeScreen(
759-
windowSizeClass = CompactWindowSizeClass,
757+
isHomeAppBarExpanded = true,
760758
isLoading = true,
761759
featuredPodcasts = PreviewPodcasts.toImmutableList(),
762760
homeCategories = HomeCategory.entries,

0 commit comments

Comments
 (0)