Skip to content

Commit 7f2df5d

Browse files
committed
Revert JDK version to 1.8 for Camera2Basic
This commit reverts the JDK version used for the Camera2Basic project to 1.8. This change addresses compatibility issues encountered with the newer JDK 17. The following changes were made: - Modified `Camera2Basic/build.gradle` to use `VERSION_1_8`. - Removed `org.gradle.java.home` from `Camera2Basic/gradle.properties`. - Removed `org.gradle.java.home` from `CameraXExtensions/gradle.properties`. - Added `.java-version` files to specify java versions.
1 parent 1a0bbd9 commit 7f2df5d

7 files changed

Lines changed: 31 additions & 7 deletions

File tree

.github/scripts/gradlew_recursive.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@ set -xe
2020
# You may edit this if your repo has a different project structure
2121
for GRADLEW in `find . -name "gradlew"` ; do
2222
SAMPLE=$(dirname "${GRADLEW}")
23+
# Initialize jenv to manage Java versions
24+
if command -v jenv &> /dev/null; then
25+
pushd "$SAMPLE"
26+
eval "$(jenv init -)"
27+
popd
28+
fi
2329
# Tell Gradle that this is a CI environment and disable parallel compilation
2430
bash "$GRADLEW" -p "$SAMPLE" -Pci --no-parallel --stacktrace $@
2531
done

.github/workflows/android.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ jobs:
4040
distribution: 'zulu'
4141
java-version: '17'
4242
- name: Build project
43-
run: |
44-
.github/scripts/gradlew_recursive.sh assembleDebug
43+
run: .github/scripts/gradlew_recursive.sh assembleDebug
4544
- name: Zip artifacts
4645
run: zip -r assemble.zip . -i '**/build/*.apk' '**/build/*.aab' '**/build/*.aar' '**/build/*.so'
4746
- name: Upload artifacts

Camera2Basic/.java-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
17

Camera2Basic/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
buildscript {
2020
// Top-level variables used for versioning
2121
ext.kotlin_version = '1.9.20'
22-
ext.java_version = JavaVersion.VERSION_17
22+
ext.java_version = JavaVersion.VERSION_1_8
2323

2424
repositories {
2525
google()

Camera2Basic/gradle.properties

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,22 @@
11

2-
org.gradle.java.home=/Users/cartland/.jenv/versions/17
3-
android.useAndroidX=true
2+
# Project-wide Gradle settings.
3+
4+
# IDE (e.g. Android Studio) users:
5+
# Settings specified in this file will override any Gradle settings
6+
# configured through the IDE.
7+
8+
# For more details on how to configure your build environment visit
9+
# http://www.gradle.org/docs/current/userguide/build_environment.html
10+
11+
# Specifies the JVM arguments used for the daemon process.
12+
# The setting is particularly useful for tweaking memory settings.
13+
# Default value: -Xmx10248m -XX:MaxPermSize=256m
14+
# org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
15+
16+
# When configured, Gradle will run in incubating parallel mode.
17+
# This option should only be used with decoupled projects. More details, visit
18+
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
19+
# org.gradle.parallel=true
20+
421
android.enableJetifier=true
22+
android.useAndroidX=true

CameraXExtensions/.java-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
17

CameraXExtensions/gradle.properties

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,4 @@ kotlin.code.style=official
3838
# thereby reducing the size of the R class for that library
3939
android.nonTransitiveRClass=true
4040
android.defaults.buildfeatures.buildconfig=true
41-
android.nonFinalResIds=false
42-
org.gradle.java.home=/Users/cartland/.jenv/versions/17
41+
android.nonFinalResIds=false

0 commit comments

Comments
 (0)