Skip to content

Commit 0e4c0c7

Browse files
silverwindandrewdeandrade
silverwind
authored and
andrewdeandrade
committed
test: enable linting for tests
Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: nodejs/node#1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 227f07f commit 0e4c0c7

985 files changed

Lines changed: 2276 additions & 1123 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.eslintignore‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
11
lib/punycode.js
2+
test/fixtures
3+
test/**/node_modules
4+
test/parallel/test-fs-non-number-arguments-throw.js

‎.eslintrc‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ ecmaFeatures:
88
octalLiterals: true
99
binaryLiterals: true
1010
generators: true
11+
forOf: true
1112

1213
rules:
1314
# Possible Errors
@@ -54,6 +55,10 @@ rules:
5455
space-infix-ops: 2
5556
## require spaces return, throw, case
5657
space-return-throw-case: 2
58+
## no space before function, eg. 'function()'
59+
space-before-function-paren: [2, "never"]
60+
## require space before blocks, eg 'function() {'
61+
space-before-blocks: [2, "always"]
5762
## require parens for Constructor
5863
new-parens: 2
5964
## max 80 length

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ bench-idle:
375375
./$(NODE_EXE) benchmark/idle_clients.js &
376376

377377
jslint:
378-
./$(NODE_EXE) tools/eslint/bin/eslint.js src lib --reset --quiet
378+
./$(NODE_EXE) tools/eslint/bin/eslint.js src lib test --reset --quiet
379379

380380
CPPLINT_EXCLUDE ?=
381381
CPPLINT_EXCLUDE += src/node_lttng.cc

‎test/.eslintrc‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
## Test-specific linter rules
2+
3+
rules:
4+
## allow unreachable code
5+
no-unreachable: 0

‎test/addons/async-hello-world/test.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
1+
'use strict';
12
var assert = require('assert');
23
var binding = require('./build/Release/binding');
34
var called = false;
45

5-
process.on('exit', function () {
6+
process.on('exit', function() {
67
assert(called);
78
});
89

9-
binding(5, function (err, val) {
10+
binding(5, function(err, val) {
1011
assert.equal(null, err);
1112
assert.equal(10, val);
12-
process.nextTick(function () {
13+
process.nextTick(function() {
1314
called = true;
1415
});
1516
});

‎test/addons/at-exit/test.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
'use strict';
12
var binding = require('./build/Release/binding');

‎test/addons/hello-world-function-export/test.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
'use strict';
12
var assert = require('assert');
23
var binding = require('./build/Release/binding');
34
assert.equal('world', binding());

‎test/addons/hello-world/test.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
'use strict';
12
var assert = require('assert');
23
var binding = require('./build/Release/binding');
34
assert.equal('world', binding.hello());

‎test/addons/repl-domain-abort/test.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
'use strict';
12
var assert = require('assert');
23
var repl = require('repl');
34
var stream = require('stream');

‎test/addons/smalloc-alloc/test.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
'use strict';
12
var assert = require('assert');
23
var binding = require('./build/Release/binding');
34
var obj = binding.alloc(16);

0 commit comments

Comments
 (0)