Skip to content

Commit d7a86ff

Browse files
committed
Fix nodejsGH-819. Drop out if connection destroyed before connect()
1 parent 7e28630 commit d7a86ff

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

lib/net.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -547,6 +547,8 @@ Socket.prototype.setEncoding = function(encoding) {
547547

548548

549549
function doConnect(socket, port, host) {
550+
if (socket.destroyed) return;
551+
550552
timers.active(socket);
551553

552554
try {

test/simple/test-regress-GH-819.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
var common = require('../common');
2+
var net = require('net');
3+
var assert = require('assert');
4+
5+
// Connect to something that we need to DNS resolve
6+
var c = net.createConnection(80, "google.com");
7+
c.destroy();

0 commit comments

Comments
 (0)