updated camera & console

Stanimir Karoserov · Stanimir Karoserov · commit 826050eda0e5 · 2014-05-21T19:05:34.000+03:00
diff --git a/camera/camera.ios.ts b/camera/camera.ios.ts
@@ -36,8 +36,7 @@ function topViewControllerWithRootViewController(rootViewController: any) {
 export var takePicture = function (options?: types.Options): promises.Promise<imageSource.ImageSource> {
     var d = promises.defer<imageSource.ImageSource>();
 
-    // FIXME: this is done to prevent listener from being freed by JS garbage collector
-    // we will try to fix this at JS Bridge level
+    // This is done to prevent listener from being freed by JS garbage collector
     var listener;
 
     var ImagePickerControllerListener = Foundation.NSObject.extends({
@@ -49,7 +48,6 @@ export var takePicture = function (options?: types.Options): promises.Promise<im
                 imagePickerControllerDidFinishPickingMediaWithInfo: function (picker, info) {
                     console.log('takeImage received');
                     picker.presentingViewController.dismissViewControllerAnimatedCompletion(true, null);
-                    // FIXME: do not work with listener here
                     listener = null;
                     var image = imageSource.fromNativeSource(info.valueForKey(UIKit.UIImagePickerControllerOriginalImage));
                     d.resolve(image);
@@ -58,7 +56,6 @@ export var takePicture = function (options?: types.Options): promises.Promise<im
                 imagePickerControllerDidCancel: function (picker) {
                     console.info('takeImage canceled');
                     picker.presentingViewController.dismissViewControllerAnimatedCompletion(true, null);
-                    // FIXME: do not work with listener here
                     listener = null;
                     d.reject(new Error('takePicture canceled by user'));
                 }
diff --git a/console/console.d.ts b/console/console.d.ts
@@ -61,4 +61,9 @@ export declare class Console {
     * @param obj The object instance to be dumped.
     */
     public dump(obj: any): void;
+
+    /**
+    * Prints the state of the specified object to the console.
+    */
+    public dir(obj: any): void;
 }
diff --git a/console/console.ts b/console/console.ts
@@ -320,4 +320,6 @@ export class Console {
         result.push('=== dump(): finished ===');
         this.log(result.join('\n'));
     }
-}
+
+    public dir = this.dump;
+}
diff --git a/declarations.d.ts b/declarations.d.ts
@@ -20,6 +20,7 @@ declare module i {
         log(message: any, ...optionalParams: any[]): void;
         trace(): void;
         dump(obj: any): void;
+        dir(obj: any): void;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -320,4 +320,6 @@ export class Console {`
`320`	`320`	`result.push('=== dump(): finished ===');`
`321`	`321`	`this.log(result.join('\n'));`
`322`	`322`	`}`
`323`		`-}`
	`323`	`+`
	`324`	`+ public dir = this.dump;`
	`325`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ declare module i {`
`20`	`20`	`log(message: any, ...optionalParams: any[]): void;`
`21`	`21`	`trace(): void;`
`22`	`22`	`dump(obj: any): void;`
	`23`	`+ dir(obj: any): void;`
`23`	`24`	`}`
`24`	`25`	`}`
`25`	`26`