Skip to content

Commit 7204fd9

Browse files
author
vakrilov
committed
OptionsMenu image form resource id
1 parent 70aa10d commit 7204fd9

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

ui/frame/frame.android.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import observable = require("data/observable");
66
import utils = require("utils/utils");
77
import view = require("ui/core/view");
88
import application = require("application");
9-
import imageSource = require("image-source");
109
import enums = require("ui/enums");
1110

1211
declare var exports;
@@ -146,9 +145,12 @@ class PageFragmentBody extends android.app.Fragment {
146145
var item = items[i];
147146
var menuItem = menu.add(android.view.Menu.NONE, i, android.view.Menu.NONE, item.text);
148147
if (item.icon) {
149-
var img = imageSource.fromResource(item.icon);
150-
var drawable = new android.graphics.drawable.BitmapDrawable(img.android);
151-
menuItem.setIcon(drawable);
148+
var androidApp = application.android;
149+
var res = androidApp.context.getResources();
150+
var id = res.getIdentifier(item.icon, 'drawable', androidApp.packageName);
151+
if (id) {
152+
menuItem.setIcon(id);
153+
}
152154
}
153155

154156
var showAsAction = PageFragmentBody.getShowAsAction(item);
@@ -179,7 +181,7 @@ class PageFragmentBody extends android.app.Fragment {
179181
menuItem._raiseTap();
180182
return true;
181183
}
182-
184+
183185
super.onOptionsItemSelected(item);
184186
}
185187
}

0 commit comments

Comments
 (0)