Skip to content

Commit 4cba61c

Browse files
author
Vladimir Enchev
committed
Second parameter (milliseconds) is now optional for setTimeout and setInterval
1 parent 4b9cc1a commit 4cba61c

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

timer/timer.android.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@ function createHadlerAndGetId() : number {
1212
return new Date().getUTCMilliseconds();
1313
}
1414

15-
export function setTimeout(callback: Function, milliseconds: number): number {
15+
export function setTimeout(callback: Function, milliseconds?: number): number {
16+
if (typeof (milliseconds) !== "number") {
17+
milliseconds = 0;
18+
}
19+
1620
var id = createHadlerAndGetId();
1721

1822
var runnable = new java.lang.Runnable({
@@ -38,7 +42,11 @@ export function clearTimeout(id: number): void {
3842
}
3943
}
4044

41-
export function setInterval(callback: Function, milliseconds: number): number {
45+
export function setInterval(callback: Function, milliseconds?: number): number {
46+
if (typeof (milliseconds) !== "number") {
47+
milliseconds = 0;
48+
}
49+
4250
var id = createHadlerAndGetId();
4351

4452
var runnable = new java.lang.Runnable({

timer/timer.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* Timer functions.
33
*/
4-
export declare function setTimeout(callback: Function, milliseconds: number): number;
4+
export declare function setTimeout(callback: Function, milliseconds?: number): number;
55
export declare function clearTimeout(id: number): void;
6-
export declare function setInterval(callback: Function, milliseconds: number): number;
6+
export declare function setInterval(callback: Function, milliseconds?: number): number;
77
export declare function clearInterval(id: number): void;

timer/timer.ios.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ function createTimerAndGetId(callback: Function, milliseconds: number, shouldRep
1616
return id;
1717
}
1818

19-
export function setTimeout(callback: Function, milliseconds: number): number {
19+
export function setTimeout(callback: Function, milliseconds?: number): number {
20+
if (typeof(milliseconds) !== "number") {
21+
milliseconds = 0;
22+
}
23+
2024
return createTimerAndGetId(callback, milliseconds, false);
2125
}
2226

@@ -28,5 +32,9 @@ export function clearTimeout(id: number): void {
2832
}
2933

3034
export function setInterval(callback: Function, milliseconds: number): number {
35+
if (typeof (milliseconds) !== "number") {
36+
milliseconds = 0;
37+
}
38+
3139
return createTimerAndGetId(callback, milliseconds, true);
3240
}

0 commit comments

Comments
 (0)