Resolve sign mismatch warnings

Dmitry-Me · Dmitry-Me · commit dd5b9f3b8209 · 2020-03-19T18:22:55.000+03:00
diff --git a/lib/platform.h b/lib/platform.h
@@ -61,19 +61,22 @@ namespace cppcheck {
         }
 
         bool isIntValue(unsigned long long value) const {
-            return value <= max_value(int_bit);
+            unsigned long long intMax = max_value(int_bit);
+            return value <= intMax;
         }
 
         bool isLongValue(long long value) const {
             return value >= min_value(long_bit) && value <= max_value(long_bit);
         }
 
         bool isLongValue(unsigned long long value) const {
-            return value <= max_value(long_bit);
+            unsigned long long longMax = max_value(long_bit);
+            return value <= longMax;
         }
 
         bool isLongLongValue(unsigned long long value) const {
-            return value <= max_value(long_long_bit);
+            unsigned long long longLongMax = max_value(long_long_bit);
+            return value <= longLongMax;
         }
 
         nonneg int char_bit;       /// bits in char

Original file line number	Diff line number	Diff line change
`@@ -61,19 +61,22 @@ namespace cppcheck {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`bool isIntValue(unsigned long long value) const {`
`64`		`- return value <= max_value(int_bit);`
	`64`	`+ unsigned long long intMax = max_value(int_bit);`
	`65`	`+ return value <= intMax;`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`bool isLongValue(long long value) const {`
`68`	`69`	`return value >= min_value(long_bit) && value <= max_value(long_bit);`
`69`	`70`	`}`
`70`	`71`
`71`	`72`	`bool isLongValue(unsigned long long value) const {`
`72`		`- return value <= max_value(long_bit);`
	`73`	`+ unsigned long long longMax = max_value(long_bit);`
	`74`	`+ return value <= longMax;`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`bool isLongLongValue(unsigned long long value) const {`
`76`		`- return value <= max_value(long_long_bit);`
	`78`	`+ unsigned long long longLongMax = max_value(long_long_bit);`
	`79`	`+ return value <= longLongMax;`
`77`	`80`	`}`
`78`	`81`
`79`	`82`	`nonneg int char_bit; /// bits in char`