Fix patching of removed URLopener class in Python 3.14

allhailwesttexas · allhailwesttexas · commit 523a8dfcf26a · 2025-06-19T09:43:12.000+10:00
The class urllib.request.URLopener has been removed in Python 3.14: python/cpython#125739 Because of this, trying to run the tests in `test__greenness.py` fails with the following on Python 3.14: ``` ERROR tests/test__greenness.py - NameError: name 'URLopener' is not defined ``` Update the patching so that we only do it for Python versions lower than 3.14.
diff --git a/eventlet/green/urllib/request.py b/eventlet/green/urllib/request.py
@@ -1,3 +1,5 @@
+import sys
+
 from eventlet import patcher
 from eventlet.green import ftplib, http, os, socket, time
 from eventlet.green.http import client as http_client
@@ -37,7 +39,12 @@
 del ftplib
 
 FTPHandler.ftp_open = patcher.patch_function(FTPHandler.ftp_open, *to_patch_in_functions)
-URLopener.open_ftp = patcher.patch_function(URLopener.open_ftp, *to_patch_in_functions)
+
+if sys.version_info < (3, 14):
+    URLopener.open_ftp = patcher.patch_function(URLopener.open_ftp, *to_patch_in_functions)
+else:
+    # Removed in python3.14+, nothing to do
+    pass
 
 ftperrors = patcher.patch_function(ftperrors, *to_patch_in_functions)
 
