fix: Make infer dummy entity join key idempotent (feast-dev#3115)

sfc-gh-madkins · web-flow · commit 1f5b1e078b41 · 2022-08-22T11:31:55.000-07:00
fix: Infer dummy entity join key once

Signed-off-by: Miles Adkins &lt;miles.adkins@snowflake.com&gt;

Signed-off-by: Miles Adkins &lt;miles.adkins@snowflake.com&gt;
diff --git a/sdk/python/feast/inference.py b/sdk/python/feast/inference.py
@@ -156,7 +156,11 @@ def update_feature_views_with_inferred_features_and_entities(
                 )
 
         # Infer a dummy entity column for entityless feature views.
-        if len(fv.entities) == 1 and fv.entities[0] == DUMMY_ENTITY_NAME:
+        if (
+            len(fv.entities) == 1
+            and fv.entities[0] == DUMMY_ENTITY_NAME
+            and not fv.entity_columns
+        ):
             fv.entity_columns.append(Field(name=DUMMY_ENTITY_ID, dtype=String))
 
         # Run inference for entity columns if there are fewer entity fields than expected.
