App Passwords: Return true when rate limiting a password's last used time.

SergeyBiryukov · SergeyBiryukov · commit e6c5728b6cbe · 2020-12-03T17:21:48.000Z
Previously we returned a `WP_Error` instance saying that the password was not found which is inaccurate. Props dlh. Reviewed by TimothyBlynJacobs, SergeyBiryukov. Merges [49739] to the 5.6 branch. Fixes #51922. git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49740 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/class-wp-application-passwords.php b/src/wp-includes/class-wp-application-passwords.php
@@ -203,7 +203,7 @@ public static function record_application_password_usage( $user_id, $uuid ) {
 
 			// Only record activity once a day.
 			if ( $password['last_used'] + DAY_IN_SECONDS > time() ) {
-				continue;
+				return true;
 			}
 
 			$password['last_used'] = time();

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ public static function record_application_password_usage( $user_id, $uuid ) {`
`203`	`203`
`204`	`204`	`// Only record activity once a day.`
`205`	`205`	`if ( $password['last_used'] + DAY_IN_SECONDS > time() ) {`
`206`		`- continue;`
	`206`	`+ return true;`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`$password['last_used'] = time();`