WPDB: When a db.php drop-in is being used, and it doesn't explicitly define itself as connecting to MySQL, skip the character set checks. This ensures that existing drop-ins won't accidentally run checks that they don't support.

pento · pento · commit de33d35d1f9e · 2014-11-18T03:37:23.000Z
See #21212. git-svn-id: https://develop.svn.wordpress.org/trunk@30375 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/wp-db.php b/src/wp-includes/wp-db.php
@@ -2211,7 +2211,7 @@ protected function get_table_charset( $table ) {
 		$this->col_meta[ $table ] = $columns;
 
 		foreach ( $columns as $column ) {
-			if ( $column->Collation ) {
+			if ( ! empty( $column->Collation ) ) {
 				list( $charset ) = explode( '_', $column->Collation );
 				$charsets[ strtolower( $charset ) ] = true;
 			}
@@ -2237,7 +2237,7 @@ protected function get_table_charset( $table ) {
 			$charset = key( $charsets );
 		} elseif ( 0 === $count ) {
 			// No charsets, assume this table can store whatever.
-			$charset = 'latin1';
+			$charset = false;
 		} else {
 			// More than one charset. Remove latin1 if present and recalculate.
 			unset( $charsets['latin1'] );
@@ -2291,6 +2291,11 @@ protected function get_col_charset( $table, $column ) {
 			return $charset;
 		}
 
+		// Skip this entirely if this isn't a MySQL database.
+		if ( false === $this->is_mysql ) {
+			return false;
+		}
+
 		if ( empty( $this->table_charset[ $table ] ) ) {
 			// This primes column information for us.
 			$table_charset = $this->get_table_charset( $table );
@@ -2378,13 +2383,12 @@ protected function strip_invalid_text( $data ) {
 		foreach ( $data as &$value ) {
 			$charset = $value['charset'];
 
-			// latin1 will happily store anything.
-			if ( 'latin1' === $charset ) {
+			// Column isn't a string, or is latin1, which will will happily store anything.
+			if ( false === $charset || 'latin1' === $charset ) {
 				continue;
 			}
 
-			// Column or value isn't a string.
-			if ( false === $charset || ! is_string( $value['value'] ) ) {
+			if ( ! is_string( $value['value'] ) ) {
 				continue;
 			}
 
diff --git a/tests/phpunit/tests/db/charset.php b/tests/phpunit/tests/db/charset.php
@@ -231,7 +231,7 @@ function test_strip_invalid_text_for_column() {
 	protected $table_and_column_defs = array(
 		array(
 			'definition'      => '( a INT, b FLOAT )',
-			'table_expected'  => 'latin1',
+			'table_expected'  => false,
 			'column_expected' => array( 'a' => false, 'b' => false )
 		),
 		array(
@@ -346,6 +346,32 @@ function test_get_column_charset( $drop, $create, $table, $expected_charset ) {
 		self::$_wpdb->query( $drop );
 	}
 
+	/**
+	 * @dataProvider data_test_get_column_charset
+	 * @ticket 21212
+	 */
+	function test_get_column_charset_non_mysql( $drop, $create, $table, $columns ) {
+		self::$_wpdb->query( $drop );
+
+		if ( ! self::$_wpdb->has_cap( 'utf8mb4' ) && preg_match( '/utf8mb[34]/i', $create ) ) {
+			$this->markTestSkipped( "This version of MySQL doesn't support utf8mb4." );
+			return;
+		}
+
+		self::$_wpdb->is_mysql = false;
+
+		self::$_wpdb->query( $create );
+
+		$columns = array_keys( $columns );
+		foreach ( $columns as $column => $charset ) {
+			$this->assertEquals( false, self::$_wpdb->get_col_charset( $table, $column ) );
+		}
+
+		self::$_wpdb->query( $drop );
+
+		self::$_wpdb->is_mysql = true;
+	}
+
 	/**
 	 * @ticket 21212
 	 */
