Minor cleanups of MCAd

Fraser J. Gordon · Fraser J. Gordon · commit 657fd3b30df5 · 2013-09-03T10:57:04.000+01:00
diff --git a/engine/src/exec-ad.cpp b/engine/src/exec-ad.cpp
@@ -417,26 +417,17 @@ void MCAdGetAds(MCExecContext& ctxt, MCStringRef& r_ads)
     bool t_success;
     t_success = false;
     
-    MCAutoStringRef t_ads;
+    MCAutoListRef t_ads;
+	/* UNCHECKED */ MCListCreateMutable('\n', &t_ads);
 	for(MCAd *t_ad = MCAdGetStaticAdsPtr(); t_ad != nil && t_success; t_ad = t_ad->GetNext())
     {
 		if (!MCStringIsEmpty(t_ad->GetName()))
-        {
-            if (*t_ads == nil)
-            {
-				t_success = MCStringMutableCopy(t_ad->GetName(), &t_ads);
-            }
-            else
-			{
-                t_success = MCStringAppendFormat(*t_ads, "\n");
-				t_success = t_success && MCStringAppend(*t_ads, t_ad->GetName());
-			}
-        }
+            t_success = MCListAppend(*t_ads, t_ad->GetName());
     }
     
     if (t_success)
     {
-        r_ads = MCValueRetain(*t_ads);
+        /* UNCHECKED */ MCListCopyAsString(*t_ads, r_ads);
         return;
     }
 
diff --git a/engine/src/mblad.cpp b/engine/src/mblad.cpp
@@ -177,10 +177,10 @@ class MCAdEvent: public MCCustomEvent
             switch(m_event)
             {
                 case kMCAdEventTypeReceive:
-                    t_object->Get()->message_with_valueref_args(MCM_ad_loaded, m_target->GetName(), kMCFalseString);
+                    t_object->Get()->message_with_valueref_args(MCM_ad_loaded, m_target->GetName(), kMCFalse);
                     break;
                 case kMCAdEventTypeReceiveDefault:
-                    t_object->Get()->message_with_valueref_args(MCM_ad_loaded, m_target->GetName(), kMCTrueString);
+                    t_object->Get()->message_with_valueref_args(MCM_ad_loaded, m_target->GetName(), kMCTrue);
                     break;
                 case kMCAdEventTypeReceiveFailed:
                     t_object->Get()->message_with_valueref_args(MCM_ad_load_failed, m_target->GetName());
