Added sanity check for the statement scores

edomora97 · edomora97 · commit 264fc5fa7575 · 2018-09-02T12:05:11.000+02:00
diff --git a/python/sanity_checks/ioi.py b/python/sanity_checks/ioi.py
@@ -45,6 +45,11 @@ def _get_statement_path():
     return None
 
 
+def _get_statement_tex():
+    return list_files(
+        ["statement/*.tex", "testo/*.tex"], valid_extensions=[".tex"])
+
+
 def _check_git_has_file(path: str) -> Optional[bool]:
     # git is not installed
     if not find_executable("git"):
@@ -61,6 +66,55 @@ def _check_git_has_file(path: str) -> Optional[bool]:
     return False
 
 
+def _check_pdf_statement(interface: IOIUIInterface):
+    path = _get_statement_path()
+    if not path:
+        interface.add_warning("The statement file is missing")
+        return
+    if _check_git_has_file(path) is False:
+        interface.add_warning(
+            "The statement file {} is not known to git".format(path))
+    if os.path.islink(path):
+        realpath = os.path.relpath(path)
+        if not os.path.exists(realpath):
+            interface.add_warning("The statement is a broken link")
+
+
+def _check_tex_statement(task: Task, interface: IOIUIInterface):
+    statements = _get_statement_tex()
+    if not statements:
+        return
+    regex = r".*\{Subtask ([0-9]+)\} *\[(?:\\phantom\{.\})?([0-9]+).*\].*"
+    for statement in statements:
+        is_non_sequential = False
+        is_wrong = False
+        with open(statement, "r") as f:
+            matches = re.findall(regex, f.read())
+            if not matches:
+                continue
+            one_based = int(matches[0][0] == '1')
+            last = -1
+            for subtask, score in matches:
+                subtask = int(subtask) - one_based
+                score = int(score)
+                if subtask != last + 1:
+                    is_non_sequential = True
+                    # if the numbers are screwed up the scores have no sense
+                    break
+                last = subtask
+                from_task = task.subtasks.get(subtask)
+                if not from_task or from_task.max_score != score:
+                    is_wrong = True
+        if is_non_sequential:
+            interface.add_warning(
+                "The subtasks in the statement {} are "
+                "non-sequentially numbered".format(statement))
+        elif is_wrong:
+            interface.add_warning(
+                "The subtasks in the statement {} don't match "
+                "the task's ones".format(statement))
+
+
 def _setup_execution_callback(interface: IOIUIInterface, execution: Execution,
                               description: str):
     log_prefix = "{} ".format(description).ljust(50)
@@ -181,26 +235,16 @@ def check_sol_folder(solutions: List[Solution], interface: IOIUIInterface):
                 "Official solution {} is not a symlink".format(sol))
 
 
-def check_statement(interface: IOIUIInterface):
+def check_statement(task: Task, interface: IOIUIInterface):
     """
     Check if the statement is present and, if git is used, that is known.
     Check that the latex statements, if present contain the same subtasks, with
     the same score, as the task
     Check if the template functions in the statement and in the graders have the
     same signature
     """
-    path = _get_statement_path()
-    if not path:
-        interface.add_warning("The statement file is missing")
-        return
-    if _check_git_has_file(path) is False:
-        interface.add_warning(
-            "The statement file {} is not known to git".format(path))
-    if os.path.islink(path):
-        realpath = os.path.relpath(path)
-        if not os.path.exists(realpath):
-            interface.add_warning("The statement is a broken link")
-    # TODO check if the subtasks match the one in the statement
+    _check_pdf_statement(interface)
+    _check_tex_statement(task, interface)
     # TODO check if the template signatures match the one in the statement
 
 
@@ -333,7 +377,7 @@ def sanity_pre_checks(task: Task, solutions: List[Solution],
     check_subtask_score_sum(task, interface)
     check_att_folder(task, solutions, interface)
     check_sol_folder(solutions, interface)
-    check_statement(interface)
+    check_statement(task, interface)
     check_sample_cases(task, frontend, config, interface)
 
 
diff --git a/python/uis/__init__.py b/python/uis/__init__.py
@@ -127,9 +127,13 @@ def getStderr(stderr):
 
     def add_warning(self, message: str):
         self.warnings.append(message)
+        self.printer.yellow("WARNING  ", bold=True)
+        self.printer.text(message.strip() + "\n")
 
     def add_error(self, message: str):
         self.errors.append(message)
+        self.printer.red("ERROR  ", bold=True)
+        self.printer.text(message.strip() + "\n")
 
 
 class FinishUI:
