Refactor mrb_str_downcase_bang()

suzukaze · suzukaze · commit e340babc1e52 · 2014-05-05T12:42:57.000+09:00
diff --git a/src/string.c b/src/string.c
@@ -1128,7 +1128,7 @@ static mrb_value
 mrb_str_downcase_bang(mrb_state *mrb, mrb_value str)
 {
   char *p, *pend;
-  int modify = 0;
+  mrb_bool modify = FALSE;
   struct RString *s = mrb_str_ptr(str);
 
   mrb_str_modify(mrb, s);
@@ -1137,7 +1137,7 @@ mrb_str_downcase_bang(mrb_state *mrb, mrb_value str)
   while (p < pend) {
     if (ISUPPER(*p)) {
       *p = TOLOWER(*p);
-      modify = 1;
+      modify = TRUE;
     }
     p++;
   }

Original file line number	Diff line number	Diff line change
`@@ -1128,7 +1128,7 @@ static mrb_value`
`1128`	`1128`	`mrb_str_downcase_bang(mrb_state *mrb, mrb_value str)`
`1129`	`1129`	`{`
`1130`	`1130`	`char p, pend;`
`1131`		`- int modify = 0;`
	`1131`	`+ mrb_bool modify = FALSE;`
`1132`	`1132`	`struct RString *s = mrb_str_ptr(str);`
`1133`	`1133`
`1134`	`1134`	`mrb_str_modify(mrb, s);`
`@@ -1137,7 +1137,7 @@ mrb_str_downcase_bang(mrb_state *mrb, mrb_value str)`
`1137`	`1137`	`while (p < pend) {`
`1138`	`1138`	`if (ISUPPER(*p)) {`
`1139`	`1139`	`p = TOLOWER(p);`
`1140`		`- modify = 1;`
	`1140`	`+ modify = TRUE;`
`1141`	`1141`	`}`
`1142`	`1142`	`p++;`
`1143`	`1143`	`}`